Closed Bug 1474131 Opened 5 years ago Closed 5 years ago

Lazily load ContentRestore.jsm

Categories

(Firefox :: Session Restore, enhancement, P1)

Product:
Firefox
Component:
Session Restore
Version:
57 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

(Whiteboard: [overhead:17K])

Attachments

(1 file)

Bug 1474131: Don't load ContentRestore.jsm before it's needed.
59 bytes, text/x-review-board-request
mconley
: review+
Details 
ContentRestore.jsm is only needed when we're actually restoring the contents of a tab, which doesn't happen that often. The gContentRestore instance is created lazily, but the JSM is always imported eagerly.
Comment on attachment 8990546 [details]
Bug 1474131: Don't load ContentRestore.jsm before it's needed.

https://reviewboard.mozilla.org/r/255604/#review262852

Looks good, thanks! I'm particularly pleased that we have a test that'll catch if this somehow regresses.
Attachment #8990546 - Flags: review?(mconley) → review+
Actively being worked on so P1
Depends on: ss-perf
Priority: -- → P1
Blocks: ss-perf
No longer depends on: ss-perf
https://hg.mozilla.org/mozilla-central/rev/1c7a0f1327eb
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.