1474150 - new TCPServerSocket should fail if port is already in use

Status: NEW

(Core :: Networking, defect, P5)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attempt to using TCPServerSocket in WebExtensions "addon_child" context does not report report any issues even if requested port is in use. Although in such case socket does not seem to function.

I suspect issue is related to the fact that web-extensions use their own process as running same code in the privileged tab like `about:addons` seems to behave as expected - exception is thrown on attempt to instantiate server socket on port that is already in use.

Comment 1

[Daniel Stenberg [:bagder]]

Feels like a webextension topic?

Comment 2

[Kris Maglione [:kmag]]

Nope. We don't support TCPServerSocket. Irakli is using this from privileged code to try to expose an API to WebExtensions.

Comment 3

[Honza Bambas (:mayhemer)]

I think it's because of this code:

https://searchfox.org/mozilla-central/rev/a80651653faa78fa4dfbd238d099c2aad1cec304/netwerk/base/nsServerSocket.cpp#360-362

We should make this optional, probably by adding a new flag at

https://searchfox.org/mozilla-central/rev/a80651653faa78fa4dfbd238d099c2aad1cec304/netwerk/base/nsIServerSocket.idl#37

Comment 4

[u408661]

Jason, I think we need some cross-team coordination to properly triage/prioritize this. Can you help out?

Comment 5

[Dragana Damjanovic [:dragana]]

To be able to triage this properly, how important is TCPServerSocket use case?

Comment 6

[Kris Maglione [:kmag]]

We don't expose this interface to WebExtensions, so I don't think it's a concern.

Comment 7

[Selena Deckelmann :selenamarie :selena]

(In reply to Irakli Gozalishvili [:irakli] [:gozala] [@gozala] from comment #0)
> Attempt to using TCPServerSocket in WebExtensions "addon_child" context does
> not report report any issues even if requested port is in use. Although in
> such case socket does not seem to function.
> 
> I suspect issue is related to the fact that web-extensions use their own
> process as running same code in the privileged tab like `about:addons` seems
> to behave as expected - exception is thrown on attempt to instantiate server
> socket on port that is already in use.

Is this blocking any work?

Comment 8

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

(In reply to Selena Deckelmann :selenamarie :selena use ni? pronoun: she from comment #7)
> (In reply to Irakli Gozalishvili [:irakli] [:gozala] [@gozala] from comment
> #0)
> > Attempt to using TCPServerSocket in WebExtensions "addon_child" context does
> > not report report any issues even if requested port is in use. Although in
> > such case socket does not seem to function.
> > 
> > I suspect issue is related to the fact that web-extensions use their own
> > process as running same code in the privileged tab like `about:addons` seems
> > to behave as expected - exception is thrown on attempt to instantiate server
> > socket on port that is already in use.
> 
> Is this blocking any work?

Short answer is - not right now. More elaborate answer would be:

It is a bug and as we'll get closer to landing http://github.com/mozilla/libdweb into the tree this would become a blocker. We aim that to be by end of the year.