1474166 - Mail envelope from manipulation

Status: NEW

(Bugzilla :: Email Notifications, enhancement)

Description

[Dylan Hardison [:dylan] (he/him)]

> On Thu, Jul 5, 2018 at 12:07 AM, Ben Cooksley <[e-mail]> wrote:

> We've recently had an issue brought up whereby a user was complaining
> that actions they were taking on our Bugzilla instance at bugs.kde.org
> were triggering SPF bounces back to them.

> I've investigated and it seems that users who have set their real name
> in Bugzilla to their email address (or any email address even) cause
> the mail which is generated to have an envelope from address which
> matches the email address in their real name field.

> I suspect this issue may be caused by us having adjusted out Bugzilla
> mail template as follows, however i'm still quite surprised that this
> would occur as the From field in the email itself shouldn't end up
> being used as the envelope from address.

> From: [% changer.name %] <[% Param('mailfrom') %]>

> Could you cast any light on this?

> Based on my research it would seem that Bugzilla needs to explicitly
> specify an envelope from sender (which it doesn't do currently) when
> sending email (as per
> https://metacpan.org/pod/distribution/Email-Sender/lib/Email/Sender.pm)
> which might be the explanation for this.

> Confirmation that this is the case would be much appreciated!

Ben went on to fix this:

> As this was causing issues for a small handful of users I ended up
> deploying https://commits.kde.org/websites/bugs-kde-org/c368c7276805cd9c46a7ff95334f2c0010dbdbb2
> which did fix the issue.

That change is attached (in a github PR)