1474273 - Add xpc::CurrentNativeGlobal(cx) helper function

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P2)

Description

[Jan de Mooij [:jandem]]

16 callers of NativeGlobal pass in JS::CurrentGlobalOrNull(cx) so let's add xpc::CurrentNativeGlobal(cx) for this so we don't have to worry about these callers anymore in bug 1474272.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Add xpc::CurrentNativeGlobal and use it instead of NativeGlobal(JS::CurrentGlobalOrNull(cx))

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8990689 [details] [diff] [review]
Add xpc::CurrentNativeGlobal and use it instead of NativeGlobal(JS::CurrentGlobalOrNull(cx))

>+++ b/dom/script/ScriptSettings.cpp
>   nsCOMPtr<nsPIDOMWindowInner> window =
>-    do_QueryInterface(xpc::NativeGlobal(JS::CurrentGlobalOrNull(aCx)));
>+    do_QueryInterface(xpc::CurrentNativeGlobal(aCx));

This could use xpc::CurrentWindowOrNull to be a bit quicker (no QI).

>+CurrentNativeGlobal(JSContext* cx);

We should probably document that this must not be called when cx is not in a Realm, right?

r=me

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c72dc399004
Add xpc::CurrentNativeGlobal and use it instead of NativeGlobal(JS::CurrentGlobalOrNull(cx)). r=bz

Comment 4

[Jan de Mooij [:jandem]]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #2)
> >+    do_QueryInterface(xpc::CurrentNativeGlobal(aCx));
> 
> This could use xpc::CurrentWindowOrNull to be a bit quicker (no QI).

Ah thanks, done.

> We should probably document that this must not be called when cx is not in a
> Realm, right?

Done.

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4c72dc399004