1474286 - Throw a JS exception in ChromeUtils::RequestPerformanceMetrics if pref is off

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Tarek Ziadé (:tarek)]

There are asserts in the content process but we should do a clean exception in ChromeUtils::RequestPerformanceMetrics in case dom.performance.enable_scheduler_timing is false

Comment 1

[Tarek Ziadé (:tarek)]

Attachment: Bug 1474286 - Throw a JS exception in ChromeUtils::RequestPerformanceMetrics if pref is off -

This change will avoid unecessary IPDL messages and potentially, content processes crashes.

Review commit: https://reviewboard.mozilla.org/r/255984/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255984/

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8990974 [details]
Bug 1474286 - Throw a JS exception in ChromeUtils::RequestPerformanceMetrics if pref is off -

https://reviewboard.mozilla.org/r/255984/#review262824

What about using [Pref="dom.performance.enable_scheduler_timing"] in ChromeUtils.webidl?

Comment 3

[Tarek Ziadé (:tarek)]

I get this issue:

 WebIDL.WebIDLError: error: [Pref] used on an interface member that is not Window-only

Because the ChromeUtils namespace is exposed to Window, System and Worker

I am not sure what should be done in that case ?

Comment 4

[Andrea Marchesini [:baku]]

>  WebIDL.WebIDLError: error: [Pref] used on an interface member that is not
> Window-only

Then, use Func= pointing to a DOMPrefs method. And add a DOM_WEBIDL_PREF in DOMPrefsInternal.h

Comment 5

[Tarek Ziadé (:tarek)]

Comment on attachment 8990974 [details]
Bug 1474286 - Throw a JS exception in ChromeUtils::RequestPerformanceMetrics if pref is off -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255984/diff/1-2/

Comment 6

[Andrea Marchesini [:baku]]

Comment on attachment 8990974 [details]
Bug 1474286 - Throw a JS exception in ChromeUtils::RequestPerformanceMetrics if pref is off -

https://reviewboard.mozilla.org/r/255984/#review263388

Comment 7

[Tarek Ziadé (:tarek)]

Comment on attachment 8990974 [details]
Bug 1474286 - Throw a JS exception in ChromeUtils::RequestPerformanceMetrics if pref is off -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255984/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39e83d83646b
Throw a JS exception in ChromeUtils::RequestPerformanceMetrics if pref is off - r=baku

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/39e83d83646b