Closed
Bug 1474335
Opened 6 years ago
Closed 6 years ago
Remove toolbar.toolbarName XBL property
Categories
(Firefox :: Toolbars and Customization, enhancement, P3)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: Gijs, Assigned: manishkk, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
899 bytes,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
With the goal of eventually removing the toolbar.xml toolbar binding from CustomizableUI, we're slowly removing parts of the binding. In this bug, we need to remove https://dxr.mozilla.org/mozilla-central/rev/085cdfb90903d4985f0de1dc7786522d9fb45596/browser/components/customizableui/content/toolbar.xml#70-72 .
|
Reporter | |
Updated•6 years ago
|
Summary: Remove toolbar.toolbarName XBL property and make consumers fetch the attribute → Remove toolbar.toolbarName XBL property
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → 1991manish.kumar
|
|
Assignee | |
Comment 1•6 years ago
|
||
Please review. Thanks
Attachment #8990751 -
Flags: review?(gijskruitbosch+bugs)
|
|
Reporter | |
Comment 2•6 years ago
|
||
Comment on attachment 8990751 [details] [diff] [review] Patch_Bug1474335 Review of attachment 8990751 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8990751 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Reporter | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/549a3e30c71c Remove toolbar.toolbarName XBL property. r=Gijs
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/549a3e30c71c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•