1474360 - Cannot paste text into input fields

Status: VERIFIED FIXED

(GeckoView :: IME, defect, P1)

Description

[Emily Kager [:ekager]]

Originally reported on Github https://github.com/mozilla-mobile/focus-android/issues/2867

Steps to reproduce:

1. Copy some text into the clipboard
2. Navigate to any site with an input field, eg: google.com
3. Hold down finger on input field

Expected behavior:

Option appears to paste; user can select to paste text
Actual behavior

A black bar above the page appears briefly with a left facing arrow (left aligned) and "Paste" text (right aligned) and disappears before a user can select Paste.

On Fennec this bar works to allow for paste. On current stable Firefox Klar (from F-Droid) the paste option appears alongside the cursor that appears for input; no bar appears.

Device information:

    Android device: LG-H810, Android 5.1
    Focus version: 6.2 (Build #221891205 Emoji image of 'lizard' 62.0.20180702164905)

Comment 1

[Chris Peterson [:cpeterson]]

P1 because this is a functionality regression compared to Focus+WebView.

Comment 2

[Chris Peterson [:cpeterson]]

Jim said he would investigate this bug.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1474360 - Don't immediately hide selection toolbar after showing it;

To conform to Android behavior, we intentionally suppress the selection
toolbar when an input is first focused. However, that code has a bug
where right after we show the selection toolbar, we still think the
toolbar should be suppressed, and therefore end up hiding the toolbar
immediately. The patch fixes that bug and introduces an ACTION_HIDE
action, which is necessary to re-hide the toolbar when the user
dismisses it manually.

Review commit: https://reviewboard.mozilla.org/r/257540/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257540/

Comment 4

[Eugen Sawin [:esawin]]

Comment on attachment 8992682 [details]
Bug 1474360 - Don't immediately hide selection toolbar after showing it;

https://reviewboard.mozilla.org/r/257540/#review264988

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8992682 [details]
Bug 1474360 - Don't immediately hide selection toolbar after showing it;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257540/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/090266754d3d
Don't immediately hide selection toolbar after showing it; r=esawin

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/090266754d3d

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8992682 [details]
Bug 1474360 - Don't immediately hide selection toolbar after showing it;

Approval Request Comment
[Feature/Bug causing the regression]: bug 1441279
[User impact if declined]: Cannot paste text in GeckoView-based apps
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: GeckoView-only fix
[String changes made/needed]: None

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8992682 [details]
Bug 1474360 - Don't immediately hide selection toolbar after showing it;

Geckoview-only fix, OK to uplift for beta 11.

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/22ec5db4a28d

Comment 11

[Sorina Florean [:sflorean]]

Tested with Nexus 5(Android 6.0.1), Samsung Galaxy Note8(Android 8.0) and LG G4(Android 5.1) on latest Beta build (62.0b11) and wasn't able to reproduce the issue. Marking 62:verified.

Comment 12

[Sorina Florean [:sflorean]]

Verified as fixed on latest Nightly build (08/16).
Device: OnePlus 5T(Android 8.1.0).

Comment 13

[Kevin Brosnan [Ex-Mozilla]]

This should have been verified in Focus or GeckoView example.

Comment 14

[Sorina Florean [:sflorean]]

Sorry for the confusion! The issue was verified also on Focus, but re-checked now with LG G4(Android 5.1) on Firefox Klar from F-Droid (version 6.1.1, build #22) and Firefox Focus from Google Play (version 6.1.1, build #322202122) and I can confirm the fix. I was able to paste into the search field e.g. google.com, amazon.com, imdb.com.

Comment 15

[Chris Peterson [:cpeterson]]

Moving some input bugs to the new GeckoView::IME component.

Comment 16

[Chris Peterson [:cpeterson]]

Removing regressionwindow-wanted keyword because this bug has been resolved.

Comment 17

[Chris Peterson [:cpeterson]]

Removing regressionwindow-wanted keyword because this bug has been resolved.

Comment 18

[Chris Peterson [:cpeterson]]

Removing regressionwindow-wanted keyword because this bug has been resolved.