Closed Bug 1474376 Opened 6 years ago Closed 6 years ago

Make mediaSource legacy constraint values "screen" and "window" mean the same

Categories

(Core :: WebRTC: Audio/Video, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: fippo, Assigned: jib)

References

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

until shipping getDisplayMedia (see https://bugzilla.mozilla.org/show_bug.cgi?id=1321221) it would be good to have an intermediate step that allows an application to have the user select from either a list of screens or windows using the 'legacy' mediaSource API.

In particular this would allow the adapter.js shim for getDisplayMedia (currently in https://github.com/webrtc/adapter/pull/841) to provide a default shim which offers the same behaviour as getDisplayMedia (which does not allow the application to restrict the choice of surfaces the user is presented with)

Speaking with my application developer hat this would also allow me to expand the user choice from either 'screen' or 'window' without having to provide my own user experience for making the choice.
I think I'll internalize this to mean: make "screen" and "window" act the same, if you don't mind.

The spec [1] considers influencing user selection to be a security issue, so I believe there is support for this.

Additionally, we want everyone to migrate to getDisplayMedia() eventually, which means not leaving any incentive to stick with the old non-standard API. 

[1] https://w3c.github.io/mediacapture-screen-share/#constraints
Assignee: nobody → jib
Rank: 16
Priority: -- → P2
Summary: provide a "any" choice for the screensharing mediaSource API → For today's screensharing API: make mediaSource constraint values "screen" and "window" mean the same
Attachment #9032337 - Attachment description: Bug 1474376 - Merge window and screen sharing for content (list fullscreen as option in window-list). r?pehrsons → Bug 1474376 - Merge window+screen sharing for content (list fullscreen as option in window-list), and get away from MediaSourceEnum. r?pehrsons
Got jkt to review the test-only change. Adding a ni? for Florian for when he returns in-case he want's a follow up.
Flags: needinfo?(florian)
Pushed by jbruaroey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9a4d3d6e59ae
Merge window+screen sharing for content (list fullscreen as option in window-list), and get away from MediaSourceEnum. r=pehrsons,florian
https://hg.mozilla.org/integration/autoland/rev/00b2966950e0
Update browser_devices_get_user_media_screen.js test w/window+screen, remove application test. r=jkt
https://hg.mozilla.org/mozilla-central/rev/9a4d3d6e59ae
https://hg.mozilla.org/mozilla-central/rev/00b2966950e0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Summary: For today's screensharing API: make mediaSource constraint values "screen" and "window" mean the same → Make mediaSource legacy constraint values "screen" and "window" mean the same
Flags: needinfo?(florian)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: