The Security panel in the Account Manager is in need of some cleanup. The patch removes the unneeded orient="vertical" on the groupboxes, since they are vertically oriented by default, centers the textboxes with the buttons, and removes some (imo) unnecessary spacing.
Comment on attachment 85190 [details] [diff] [review] patch Look good to me. r=kaie
Attachment #85190 - Flags: review+
Can you post a screen shot showing what the dialog looks like with your changes?
mscott, the right image in http://bugzilla.mozilla.org/showattachment.cgi? attach_id=85188 is what the dialog looks like with the changes.
*duh* don't know how I missed that attachment. I believe the spec shows the space before the cert text after the checkbox (for encryption) and after the radio buttons (for the signing text). In addition I think the original picture (and as such the spec) looks better with that space. Can you please put back the two thin separators before these lines of text. Then I'll sr it. Thanks.
Created attachment 86267 [details] [diff] [review] patch v1.1
Attachment #85190 - Attachment is obsolete: true
Comment on attachment 86267 [details] [diff] [review] patch v1.1 Diffing your patches shows, the only change is, you are no longer removing two of the thin separators. Fine with me. r=kaie
Attachment #86267 - Flags: review+
Comment on attachment 86267 [details] [diff] [review] patch v1.1 sr=mscott
Attachment #86267 - Flags: superreview+
C:\moz_src\mozilla\mailnews\extensions\smime\resources\content>cvs commit -m "Bug 147438. Security panel needs some cleanup. Patch by Stephen Walker <email@example.com> r=kaie, sr=mscott" am-smime.xul Checking in am-smime.xul; /cvsroot/mozilla/mailnews/extensions/smime/resources/content/am-smime.xul,v <-- am-smime.xul new revision: 1.9; previous revision: 1.8 done
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Is this in the trunk as well? It is not in the Trunk build as of 20020614. Usually I mark these verified after landing on trunk, and then add the verified1.0.1 keyword after landing on branch.
this bug fix is ONLY in the trunk. It was never nominated nor approved for the branch. Nor do we want to take it for the branch. Why do you think it's in the branch? (I'm asking in case we need to raise a flag) According to CVS it is in the trunk and not the branch *phew*: http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/mailnews/extensions/smime/resources/content/am-smime.xul
I mention this because I do not see the fix in either the Trunk or thebranch builds on Windows 2k. I still see the old UI (In particular, I am looking at the box corner that matches up with the accounts button and still see the old positioning.)
Hmmm...I'm using 2002061208 and I think see the changes in my trunk build. I think the only visible change you should be able to notice is the texboxes and the buttons being centered together. Plus the removal of one small piece of veritcal space between the sign box and the encryption box. Everything else wouldn't show up in the UI, it was under the hood cleanup.
Ok - I see it now. The before after images threw me off, since I was looking at the placement of the lines inaddition to the other changes. Very subtle fix. verified.
Status: RESOLVED → VERIFIED
Component: Security: S/MIME → Security: S/MIME
Product: Core → MailNews Core
QA Contact: carosendahl → s.mime
You need to log in before you can comment on or make changes to this bug.