Closed
Bug 1474419
Opened 7 years ago
Closed 7 years ago
Update yamscripts and other files for browser/components/newtab location
Categories
(Firefox :: New Tab Page, enhancement, P2)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: Mardak, Assigned: ursula)
References
Details
This might happen as part of bug 1474414 and ported back to git, but I split this out for now as the moving of files is all within m-c, while these scripts are for activity-stream repository.
At a glance, these scripts need to be updated:
- mochitest
- buildmc (we can't blow away the whole directory anymore…)
- startmc
- importmc
Most are just changing the endpoint, but buildmc…
k88hudson, should we just track all of the existing browser/components/newtab files as part of activity-stream repository, so that an export can just delete the directory and copy things over? There might be some niceties where aboutNewTabService, AboutNewTab, NewTabUtils, and all activity stream stuff can be changed in a single activity-stream commit… ?
Flags: needinfo?(khudson)
Comment 1•7 years ago
|
||
I think it makes sense to keep the directories mirrored, it's also useful to be able to coordinate changes with aboutNewTabService.
Flags: needinfo?(khudson)
Updated•7 years ago
|
Severity: normal → enhancement
Reporter | ||
Comment 2•7 years ago
|
||
Okay, I guess part of fixing this bug is checking in the browser/components/newtab directory (pre-activity-stream-move files) to activity-stream repository.
Reporter | ||
Comment 3•7 years ago
|
||
We can also remove buildmc:version and bin/update-version.js if not already removed.
Reporter | ||
Comment 4•7 years ago
|
||
There's some references outside of yamscripts but within activity-stream repository:
https://github.com/mozilla/activity-stream/search?q=browser/extensions/activity-stream
https://searchfox.org/mozilla-central/search?q=browser/extensions/activity-stream&path=browser/extensions/activity-stream
Summary: Update yamscripts for browser/components/newtab location → Update yamscripts and other files for browser/components/newtab location
Updated•7 years ago
|
Iteration: 63.3 - Aug 6 → 63.4 - Aug 20
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → usarracini
Iteration: 63.4 - Aug 20 → 63.3 - Aug 6
Comment 5•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/f331b10db03ffc8bc913657730d65a4b1abe0ad2
Fix Bug 1474419 - Update yamscripts and other files for browser/components/newtab location
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•7 years ago
|
||
status-firefox63:
--- → fixed
Target Milestone: --- → Firefox 63
Updated•6 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•