Closed Bug 147447 Opened 24 years ago Closed 5 years ago

Font-Size greater (ctrl++) and smaller (ctrl+-) can be overriden by page

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

defect
Not set
major

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: etriebel, Unassigned)

References

()

Details

(Keywords: access, helpwanted)

Go to URL. Click 'Hilfe' on the right top. Then you get on the right side a list with 'Allgemein' 'Browser' 'Navigation' 'Seiten' 'Tastatur' 'Über..' 'Download'. Standard is 'Tastatur'. Try ctrl-. It works. Click on 'Browser'. Try ctrl- or ctrl+ - it won't work. It works only on 'Allgemein' and 'Tastatur'. What is it? Let me know.
<body onload="laber(42)" onkeydown="taste(window.event.keyCode)"> This is screwing things up, since the onkeydown handler errors and then the handler for resizing the text never gets to fire. We should be executing the ctrl-+ and ctrl-- during capture, not during bubbling, I would say... As it stands, any site can override it!
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: access
OS: Windows 98 → All
Hardware: PC → All
Summary: Font-Size greater (ctrl++) and smaller (ctrl+-) don't work properly. → Font-Size greater (ctrl++) and smaller (ctrl+-) can be overriden by page
i'm not well in english and your additonal comment was hard work for me to understand, but i think i've got it. as i see, you haven't got the main problem. you can see on eckhart.de, that all pages have <body onload="laber(x)" onkeydown="taste(window.event.keyCode)">, because i wanted to get my pages on a simple keystroke. that works very fine on netscape 4.x and fine on ie >=4.x, 'cause there you have to click first in on of the four frames, preferably in the greatest. unfortunately Mozilla 1.0 reacts to none of the keystrokes. just try it. go to eckhart.de with netscape 4.x (6.x i don't know) and after all has loaded, tip 'l'. now you'll have the page 'Leben'. tip 'g' and you'll have 'Geschichte'. tip '8' and you will have the list of all internal keystrokes. the "screwed thing up" is, that ONLY - of ALL keystrokes, five pages wan't react to ctrl- or ctrl+; and these five pages are only up to help ('Hilfe'). i do not see it. ecka
The mail I just sent Eckhart: > <<body onload="laber(x)" onkeydown="taste(window.event.keyCode)">, That code only runs for IE, not for NS4. NS4 is using the code in the .js file that does: if (navigator.appName == "Netscape") { window.captureEvents(Event.KEYPRESS); window.onkeypress = taste; } In Mozilla, appName == "Netscape" is true. So window.onkeypress is set to "taste". _But_ Mozilla also supports the onkeydown code that NS4 does not. The |onkeydown="taste(window.event.keyCode)"| code uses |window.event| which is an IE-only thing. Using "event" instead of "window.event" will work in both IE and Mozilla (since "event" is the event passed to the handler function, which is what you want after all). So the fact that the site does not work is a bug in the site. The fact that it makes text zoom not work either is a bug in Mozilla.
*** Bug 148068 has been marked as a duplicate of this bug. ***
Bug 148608 is not a duplicate of this, I mistyped the bug number. Sorry.
Keywords: helpwanted
Assignee: aaronleventhal → mats.palmgren
Depends on: 380637
QA Contact: bugzilla → keyboard.navigation
Assignee: matspal → nobody
Component: Keyboard: Navigation → User events and focus handling

Marking this as Resolved > Worksforme since the issue is not occurring anymore using Release 93.0, Beta 94.0b2 and latest Nightly 95.0a1 (2021-10-07) on Windows 10, Ubuntu 20.04 and MacOS 11.6.
If anyone else is able to reproduce it please re-open the issue or file a new one.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.