Closed Bug 1474517 Opened Last year Closed Last year

Sync rsdparsa from github

Categories

(Core :: WebRTC: Networking, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: drno, Assigned: drno)

Details

Attachments

(1 file)

59 bytes, text/x-review-board-request
johannes.willbold
: review+
Details
No description provided.
Attachment #8990910 - Flags: review?(johannes.willbold)
Comment on attachment 8990910 [details]
Bug 1474517: merge rsdparsa from upstream

https://reviewboard.mozilla.org/r/255922/#review262934

::: media/webrtc/signaling/src/sdp/rsdparsa/tests/unit_tests.rs:77
(Diff revision 1)
>  }
>  
>  #[test]
> +fn parse_minimal_sdp_with_most_media_types() {
> +    let sdp = "v=0\r\n
> +o=- 0 0 IN IP4 0.0.0.0\r\n

nit: fix indent

::: media/webrtc/signaling/src/sdp/rsdparsa/tests/unit_tests.rs:96
(Diff revision 1)
> +    assert_eq!(sdp.version, 0);
> +    assert_eq!(sdp.session, "-");
> +    assert_eq!(sdp.attribute.len(), 0);
> +    assert_eq!(sdp.media.len(), 1);
> +
> +    let msection = &(sdp.media[0]);

Is the borrowing here required?
Attachment #8990910 - Flags: review?(johannes.willbold) → review+
Comment on attachment 8990910 [details]
Bug 1474517: merge rsdparsa from upstream

https://reviewboard.mozilla.org/r/255922/#review262934

> nit: fix indent

Not sure how. I can't simply indent, because then the test string will contain all the leading whites spaces or tabs. I have failed to find another way to do line wrapping in Rust.

> Is the borrowing here required?

I can not use the convenience |msection| here. But then it is requiring a lot more typing.
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/ff25d41b504f
merge rsdparsa from upstream r=johannes.willbold+610943
https://hg.mozilla.org/mozilla-central/rev/ff25d41b504f
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.