1474517 - Sync rsdparsa from github

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, enhancement, P2)

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1474517: merge rsdparsa from upstream

Updated rsdparsa to 75d5c6df6728fbab502db06940062e0358536f9f from github
upstream

Review commit: https://reviewboard.mozilla.org/r/255922/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255922/

Comment 2

[Johannes Willbold]

Comment on attachment 8990910 [details]
Bug 1474517: merge rsdparsa from upstream

https://reviewboard.mozilla.org/r/255922/#review262934

::: media/webrtc/signaling/src/sdp/rsdparsa/tests/unit_tests.rs:77
(Diff revision 1)
>  }
>  
>  #[test]
> +fn parse_minimal_sdp_with_most_media_types() {
> +    let sdp = "v=0\r\n
> +o=- 0 0 IN IP4 0.0.0.0\r\n

nit: fix indent

::: media/webrtc/signaling/src/sdp/rsdparsa/tests/unit_tests.rs:96
(Diff revision 1)
> +    assert_eq!(sdp.version, 0);
> +    assert_eq!(sdp.session, "-");
> +    assert_eq!(sdp.attribute.len(), 0);
> +    assert_eq!(sdp.media.len(), 1);
> +
> +    let msection = &(sdp.media[0]);

Is the borrowing here required?

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 8990910 [details]
Bug 1474517: merge rsdparsa from upstream

https://reviewboard.mozilla.org/r/255922/#review262934

> nit: fix indent

Not sure how. I can't simply indent, because then the test string will contain all the leading whites spaces or tabs. I have failed to find another way to do line wrapping in Rust.

> Is the borrowing here required?

I can not use the convenience |msection| here. But then it is requiring a lot more typing.

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8990910 [details]
Bug 1474517: merge rsdparsa from upstream

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255922/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff25d41b504f
merge rsdparsa from upstream r=johannes.willbold+610943

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ff25d41b504f