1474519 - [Regression] Undo button does not appear when closing all tabs in private mode

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P2)

Description

[Isabel Rios[:isabel_rios]]

Started to happen on master after this commit: 8731cb65faa64690a2b27742cd5ea34ac0ed3274

https://github.com/mozilla-mobile/firefox-ios/commit/8731cb65faa64690a2b27742cd5ea34ac0ed3274

Steps:
Go to private mode and open several tabs
Go to tab tray and tap on the close button, select close all

Expected:
After all tabs are closed there is a toast button to Undo

Actual:
The Undo toast button does not appear


More info:
This is the automated test that caught the issue:
https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5b4405162e65fa00014b5eb2/test/3602b9e4-e891-4622-abad-c18a5f20dd84/f13841d6-4ec3-4716-b5f8-7a8ce6132ee6

It is also reproducible following the steps manually.

Comment 1

[:garvan]

I thought this was by-design, if not, it seems reasonable to not offer this because it fits with the messaging that tab history is not stored in pb mode.

Comment 2

[Isabel Rios[:isabel_rios]]

The undo option has been available in private mode also at least since the test is running and passing being implemented in that way.

Sorry but I disagree here :) For me it makes sense to have this option since it would allow you to recover your closed tabs if you close them by mistake. The Undo option is shown only for a few seconds, so if all tabs are closed and you don't undo, the history is removed and not stored.

Comment 3

[Isabel Rios[:isabel_rios]]

This has been fixed by this PR: https://github.com/mozilla-mobile/firefox-ios/commit/1508decfb4c085e22a7b9ec52b5e4f5058c20d9c