1474658 - RTCRtpStreamStats.ssrc should be an unsigned long

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P3)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

RTCRtpStreamStats.ssrc is defined in our WebIDL as a string [0], while in the spec it is defined as an unsigned long [1]. We should fix that.

[0] https://searchfox.org/mozilla-central/source/dom/webidl/RTCStatsReport.webidl#30
[1] https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8cd643d77383f43c64e09106af6b22560c871f00

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1474658 - P1 - fix type of RTCRtpStreamStats to match WebIDL spec

At some point the type of the ssrc field changed to an unsigned long.

Review commit: https://reviewboard.mozilla.org/r/256682/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256682/

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1474658 - P2 - RTCRtpStreamStats.ssrc is now a unsigned long

RTCRtpStreamStats.ssrc used to be a DOMString but is now an unsigned long.
When gathering this stat it needs to be constructed accordingly.

Review commit: https://reviewboard.mozilla.org/r/256684/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256684/

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1474658 - P3 - Expect RTCRtpStreamStats.ssrc to be an unsigned long in mochitests

The PeerConnection mochitest wrapper had checks to make sure that the ssrc was reported as a string.
It is now an unsigned long and those tests needed to reflect that.

Review commit: https://reviewboard.mozilla.org/r/256686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256686/

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8991745 [details]
Bug 1474658 - P1 - fix type of RTCRtpStreamStats to match WebIDL spec

https://reviewboard.mozilla.org/r/256682/#review263546

Comment 6

[Michael Froman [:mjf]]

Comment on attachment 8991747 [details]
Bug 1474658 - P3 - Expect RTCRtpStreamStats.ssrc to be an unsigned long in mochitests

https://reviewboard.mozilla.org/r/256686/#review264024

Looks good to me.

Comment 7

[Michael Froman [:mjf]]

Comment on attachment 8991746 [details]
Bug 1474658 - P2 - RTCRtpStreamStats.ssrc is now a unsigned long

https://reviewboard.mozilla.org/r/256684/#review264038

Looks good to me.

Comment 8

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa4b10ec93d2a5e64cae16cc24a7ec034d75f64f

Comment 9

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8991746 [details]
Bug 1474658 - P2 - RTCRtpStreamStats.ssrc is now a unsigned long

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256684/diff/1-2/

Comment 10

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8991747 [details]
Bug 1474658 - P3 - Expect RTCRtpStreamStats.ssrc to be an unsigned long in mochitests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256686/diff/1-2/

Comment 11

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f1be4086bca67ff78d99f73519a86bb36ccb02e

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eef45271f23c
P1 - fix type of RTCRtpStreamStats to match WebIDL spec r=smaug
https://hg.mozilla.org/integration/autoland/rev/c0f9393d2197
P2 - RTCRtpStreamStats.ssrc is now a unsigned long r=mjf
https://hg.mozilla.org/integration/autoland/rev/8149fe4ffa8b
P3 - Expect RTCRtpStreamStats.ssrc to be an unsigned long in mochitests r=mjf

Comment 13

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/eef45271f23c
https://hg.mozilla.org/mozilla-central/rev/c0f9393d2197
https://hg.mozilla.org/mozilla-central/rev/8149fe4ffa8b