1474705 - Improve formatting of about:license

Status: RESOLVED FIXED

(Firefox :: General, task, P3)

Description

[Joe Hildebrand [:jhildebrand] (UTC-6)]

In Firefox, the text that is added to describe how a license is used is not distinct enough from the license text itself, leading to potential confusion.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

The file is:
https://searchfox.org/mozilla-central/source/toolkit/content/license.html

Comment 3

[Louis Mascari]

Hey Sylvestre, I'm a new contributor and would be happy to work on this if it's still warranted. I'm viewing the license.html file, can you help me understand which aspects are too similar and if there's a preferred way to further differentiate them? Thanks.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Maybe we could do something like:

<table>
<tr><td>Name</td><td>Paths</td><td>License</td></tr>
<tr><td>Xiph.org Foundation License</td>
<td>  media/libogg/, 2002
    media/libtheora/, 2002-2007
    media/libvorbis/, 2002-2004
    media/libspeex_resampler/, 2002-2008
</td>
<td>
Copyright (c) <year>, Xiph.org Foundation

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:

- Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.

- Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.

- Neither the name of the Xiph.org Foundation nor the names of its
contributors may be used to endorse or promote products derived from
this software without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION
OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</td>
</tr>
</table>

That might clarify the display

Comment 5

[Louis Mascari]

Thank you Sylvestre, I'm working on that now.

I see that the "Apache License 2.0 with LLVM exception" is missing from the license.html document yet has a hyperlink in the unordered list linking to each license at line 66. Currently I have it commented out, is this something that should be added? Or should I just leave it as I modified it - commented out?

I've also noticed a few licenses, as I'm reformatting, are missing from that initial unordered list of links so have been creating them as I go. Lastly some of the licenses have been out of alphabetical order so rearranging that as I go.

Thanks.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

yes, don't hesitate to fix them but please make sure that they are mentioned in the commit

and yes, this isn't perfect ;)

Comment 7

[Louis Mascari]

Attachment: Bug 1474705 - Improve formatting of about:license. r?Sylvestre!

Comment 8

[Louis Mascari]

Attachment: Bug 1474705 - Improve formatting of about:license. r?Sylvestre!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82c7a343a1a1
Improve formatting of about:license. r=sylvestre

Comment 10

[Serban Stanca [:SerbanS]]

Backed out for causing linting opt failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/toolkit/content/license.html:6078:24 | references unknown path media/libtheora/ (license)

Comment 11

[Louis Mascari]

I believe this has been addressed now Serban, thank you. The amended commit has been pushed to moz-phab and is awaiting acceptance.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efab98b378a9
Improve formatting of about:license. r=sylvestre

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/efab98b378a9