Closed
Bug 1474712
Opened 7 years ago
Closed 7 years ago
Fix the ssrc parsing in the rust SDP parser
Categories
(Core :: WebRTC: Signaling, enhancement, P2)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: johannes.willbold, Assigned: johannes.willbold)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The ssrc-attribute:
a=ssrc:2082260239 msid:1d0cdb4e-5934-4f0f-9f88-40392cb60d31 315b086a-5cb6-4221-89de-caf0b038c79d
looks different after parsing and serializing it in rust:
a=ssrc:2082260239 msid:1d0cdb4e-5934-4f0f-9f88-40392cb60d31
Updated•7 years ago
|
Assignee: nobody → johannes.willbold
Blocks: rust_sdp_parser
Status: UNCONFIRMED → NEW
Rank: 15
Ever confirmed: true
Priority: -- → P2
| Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8991382 [details]
Bug 1474712: Added support for whitespace seperacted ssrc-values in the Rust parser,
https://reviewboard.mozilla.org/r/256284/#review263794
::: commit-message-aff06:3
(Diff revision 1)
> +Bug 1474712: Added support for whitespace seperacted ssrc-values in the Rust parser, r=bwc
> +
> +Added support for whitespace seperated ssrc-values
The term of art for attributes like this is "source-level attributes", so what we're doing here is adding support for whitespace in source-level attributes.
Attachment #8991382 -
Flags: review?(docfaraday) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/184bfdb02d7a
Added support for whitespace seperacted ssrc-values in the Rust parser, r=bwc
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•