Closed Bug 1474712 Opened 6 years ago Closed 6 years ago

Fix the ssrc parsing in the rust SDP parser

Categories

(Core :: WebRTC: Signaling, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: johannes.willbold, Assigned: johannes.willbold)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The ssrc-attribute:
a=ssrc:2082260239 msid:1d0cdb4e-5934-4f0f-9f88-40392cb60d31 315b086a-5cb6-4221-89de-caf0b038c79d

looks different after parsing and serializing it in rust:
a=ssrc:2082260239 msid:1d0cdb4e-5934-4f0f-9f88-40392cb60d31
Assignee: nobody → johannes.willbold
Status: UNCONFIRMED → NEW
Rank: 15
Ever confirmed: true
Priority: -- → P2
Comment on attachment 8991382 [details]
Bug 1474712: Added support for whitespace seperacted ssrc-values in the Rust parser,

https://reviewboard.mozilla.org/r/256284/#review263794

::: commit-message-aff06:3
(Diff revision 1)
> +Bug 1474712: Added support for whitespace seperacted ssrc-values in the Rust parser, r=bwc
> +
> +Added support for whitespace seperated ssrc-values

The term of art for attributes like this is "source-level attributes", so what we're doing here is adding support for whitespace in source-level attributes.
Attachment #8991382 - Flags: review?(docfaraday) → review+
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/184bfdb02d7a
Added support for whitespace seperacted ssrc-values in the Rust parser, r=bwc
https://hg.mozilla.org/mozilla-central/rev/184bfdb02d7a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: