All tabs menu styles missing for keyboard navigation

VERIFIED FIXED in Firefox 62

Status

()

defect
P1
normal
VERIFIED FIXED
10 months ago
9 months ago

People

(Reporter: mstriemer, Assigned: mstriemer)

Tracking

({access, regression})

unspecified
Firefox 63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox61 unaffected, firefox62 verified, firefox63 verified)

Details

Attachments

(4 attachments)

(Assignee)

Description

10 months ago
When navigating the all tabs menu with the keyboard there are no focus styles for the list of tabs in the main menu or hidden tabs menu.
Comment hidden (mozreview-request)

Comment 2

10 months ago
mozreview-review
Comment on attachment 8991122 [details]
Bug 1474728 - Fix focus styles in all tabs menu

https://reviewboard.mozilla.org/r/256102/#review263082

::: browser/themes/shared/tabs.inc.css:795
(Diff revision 1)
>  .all-tabs-item[selected][tabIsVisible] {
>    box-shadow: inset -4px 0 ThreeDShadow, inset 4px 0 var(--blue-40);
>  }
>  
> -.all-tabs-button,
> -.all-tabs-secondary-button {
> +.all-tabs-item:hover > .all-tabs-button:hover,
> +.all-tabs-item:hover > .all-tabs-secondary-button:hover {

What's the point of the .all-tabs-item:hover part? :hover on a child already implies :hover on a parent, doesn't it?

Generally, can you please document what this code is meant to do?
Attachment #8991122 - Flags: review?(dao+bmo)

Updated

10 months ago
Blocks: 1446101
Component: Tabbed Browser → Theme
Keywords: access, regression
Priority: -- → P1
Comment hidden (mozreview-request)
(Assignee)

Comment 4

10 months ago
mozreview-review-reply
Comment on attachment 8991122 [details]
Bug 1474728 - Fix focus styles in all tabs menu

https://reviewboard.mozilla.org/r/256102/#review263082

> What's the point of the .all-tabs-item:hover part? :hover on a child already implies :hover on a parent, doesn't it?
> 
> Generally, can you please document what this code is meant to do?

That was needed for specificity. I removed the double :hover and left it as !important, but moved it next to the item's :hover style.

Comment 6

10 months ago
mozreview-review
Comment on attachment 8991122 [details]
Bug 1474728 - Fix focus styles in all tabs menu

https://reviewboard.mozilla.org/r/256102/#review263358
Attachment #8991122 - Flags: review?(dao+bmo) → review+

Comment 7

10 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf6c59d38c9c
Fix focus styles in all tabs menu r=dao

Comment 8

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bf6c59d38c9c
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63

Comment 9

10 months ago
Posted image Bug1474728.gif
This issue is verified as fixed on Firefox 63.0a1 (20180712220034) under Win 7 64-bit and Mac OS X 10.13.3.

Please see the attached video.

Updated

10 months ago
Status: RESOLVED → VERIFIED

Updated

10 months ago
Depends on: 1475535
(Assignee)

Comment 10

9 months ago
Comment on attachment 8991122 [details]
Bug 1474728 - Fix focus styles in all tabs menu

Approval Request Comment
[Feature/Bug causing the regression]: bug 1446101
[User impact if declined]: Keyboard navigation in the all tabs menu is not visible
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: 
  1. Open enough tabs (or hide a tab) to see the all tabs button
  2. Open the all tabs menu
  3. Navigate the menu using the arrow keys/space/enter
  4. Verify that tabs are visually highlighted when they are active
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small CSS change to make a single rule more specific
[String changes made/needed]: No
Attachment #8991122 - Flags: approval-mozilla-beta?
Comment on attachment 8991122 [details]
Bug 1474728 - Fix focus styles in all tabs menu

CSS fix for regression in 62, verified in nightly.  Let's uplift for beta 10.
Attachment #8991122 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 13

9 months ago
Posted image Bug1474728.gif
This issue is verified as fixed on Firefox 62.0b10 (20180719140244) under Win 7 64-bit and Mac OS X 10.13.3.

Please see the attached video.
You need to log in before you can comment on or make changes to this bug.