Closed Bug 1474759 Opened Last year Closed 9 months ago

Add reason strings to the various MOZ_CRASH()es in Linux sandboxing

Categories

(Core :: Security: Process Sandboxing, enhancement, P3)

Unspecified
Linux
enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: jld, Assigned: brendaadel96)

Details

Attachments

(1 file)

We have a lot of MOZ_CRASH() with no arguments, which might be reasonable for developers if there's already a log message saying what the problem is, but is unhelpful when handling crash reports.

For example, the crash “signature” [@ mozilla::SetCurrentProcessSandbox ] with no reason string could have a number of different causes (note that a lot of Sandbox.cpp gets inlined into that function due to having exactly one call site), which can't be aggregated on in a search; I wound up having to pick a few crashes arbitrarily from the list, look up the line number in the source, and hope they're representative.
Priority: -- → P3

Hello, my name is Brenda Adel, I'm from the Outreachy program and I will be working at this bug with David Parks.

Assignee: nobody → brendaadel96

Before this change there was 9 empty MOZ_CRASH in linux sandboxing module , I added literal strings that explain the error in 8 of them

Attachment #9052191 - Attachment description: Bug 1474759 - added strings to the empty MOZ_Crash() in Linux sandboxing module. → Bug 1474759 - added strings to the empty MOZ_Crash() in Linux sandboxing module-checkin-needed.
Attachment #9052191 - Attachment description: Bug 1474759 - added strings to the empty MOZ_Crash() in Linux sandboxing module-checkin-needed. → Bug 1474759 - added strings to the empty MOZ_Crash() in Linux sandboxing module.
Keywords: checkin-needed

Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ab551124db7
added strings to the empty MOZ_Crash() in Linux sandboxing module. r=handyman

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.