1474759 - Add reason strings to the various MOZ_CRASH()es in Linux sandboxing

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, enhancement, P3)

Description

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

We have a lot of MOZ_CRASH() with no arguments, which might be reasonable for developers if there's already a log message saying what the problem is, but is unhelpful when handling crash reports.

For example, the crash “signature” [@ mozilla::SetCurrentProcessSandbox ] with no reason string could have a number of different causes (note that a lot of Sandbox.cpp gets inlined into that function due to having exactly one call site), which can't be aggregated on in a search; I wound up having to pick a few crashes arbitrarily from the list, look up the line number in the source, and hope they're representative.

Comment 1

[Brenda adel]

Hello, my name is Brenda Adel, I'm from the Outreachy program and I will be working at this bug with David Parks.

Comment 2

[Brenda adel]

Attachment: Bug 1474759 - added strings to the empty MOZ_Crash() in Linux sandboxing module.

Before this change there was 9 empty MOZ_CRASH in linux sandboxing module , I added literal strings that explain the error in 8 of them

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ab551124db7
added strings to the empty MOZ_Crash() in Linux sandboxing module. r=handyman

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/2ab551124db7