1474825 - Crash in mozilla::dom::ServiceWorker::Create

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-64ba23b2-ea3a-4a6a-9093-ef0690180711.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::ServiceWorker::Create dom/serviceworkers/ServiceWorker.cpp:74
1 xul.dll nsGlobalWindowInner::GetOrCreateServiceWorker dom/base/nsGlobalWindowInner.cpp:6422
2 xul.dll mozilla::dom::ServiceWorkerContainer::ServiceWorkerContainer dom/serviceworkers/ServiceWorkerContainer.cpp:93
3 xul.dll mozilla::dom::ServiceWorkerContainer::Create dom/serviceworkers/ServiceWorkerContainer.cpp:80
4 xul.dll mozilla::dom::Navigator::ServiceWorker dom/base/Navigator.cpp:1461
5 xul.dll mozilla::dom::ClientSource::SetController dom/clients/manager/ClientSource.cpp:441
6 xul.dll mozilla::dom::ClientSource::Control dom/clients/manager/ClientSource.cpp:494
7 xul.dll void mozilla::dom::ClientSourceOpChild::DoSourceOp<RefPtr<mozilla::MozPromise<mozilla::dom::ClientOpResult, nsresult, 0> >  dom/clients/manager/ClientSourceOpChild.cpp:45
8 xul.dll mozilla::dom::ClientSourceChild::RecvPClientSourceOpConstructor dom/clients/manager/ClientSourceChild.cpp:49
9 xul.dll mozilla::dom::PClientSourceChild::OnMessageReceived ipc/ipdl/PClientSourceChild.cpp:295

=============================================================

There are 14 crashes (from 10 installations) in nightly 63 with buildid 20180710222524. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1459209.

[1] https://hg.mozilla.org/mozilla-central/rev?node=a5c3aa4b30f9

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1474825 - Don't assume these are non-null. r=asuth

I guess because, in the old world, registrations were propagated everywhere we
could end up in a state with an old ServiceWorkerRegistrationInfo while our
ServiceWorkerRegistration thought that everything was up to date. I think that
what should eventually happen will be that when we eventually get our updated
Info, we'll update the state of the ServiceWorkerRegistration accordingly and
things should work themselves out.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

I'm lost in a sea of bugs. This should be fixed by the patch for bug 1474898.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Looks like it was fixed by bug 1474898.
Do you agree?

Comment 4

[Calixte Denizet (:calixte)]

Yes I agree