147485 - Installing theme crashes Mozilla when old copies of theme JAR still in user chrome directory

Status: VERIFIED DUPLICATE of bug 147672

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Greg K.]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0rc3)
Gecko/20020523
BuildID:    2002052305

When multiple copies of an old theme are still resident in the user's chrome
directory, installing the current version of the theme crashes Mozilla.

Reproducible: Always
Steps to Reproduce:
1. Download the attached archive containing six old copies of the Pinstripe JAR
2. Install all six in your Mozilla user chrome directory
3. Launch Mozilla
4. Install the current Pinstripe theme from
[http://www.kmgerich.com/pinstripe/pinstripe.html]

Actual Results:  Mozilla crashed.

Expected Results:  Mozilla should have installed the theme and not crashed.

Manually removing old copies of the theme result in Mozilla installing the new
theme without crashing.

Comment 1

[Greg K.]

Correction: the theme archive is not attached, as it is too large. It can be
downloaded from [http://greg.tcp.com/mozilla/147485/Pinstripes.sit.bin].

The Crash Report will be attached shortly.

Comment 2

[Greg K.]

Attachment: Crash Report showing stack condition at time of crash.

Comment 3

[Boris Zbarsky [:bzbarsky]]

to file networking based on that stack.

Comment 4

[Kevin Gerich]

I experienced the crash when trying to install GrayModern
(http://themes.mozdev.org/skins/graymodern.html) after having installed it once
already.

Comment 5

[Doug Turner (:dougt)]

This Recycle is the problem:

http://lxr.mozilla.org/mozilla1.0/source/xpinstall/src/nsInstall.cpp#2837

Comment 6

[Daniel Veditz [:dveditz]]

I fixed this independently this morning.

*** This bug has been marked as a duplicate of 147672 ***

Comment 7

[Greg K.]

*** Bug 148581 has been marked as a duplicate of this bug. ***

Comment 8

[timeless]

vrfy dupe