1474891 - A TP icon is shown on about: pages if you've visited a tracking website before

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Darkspirit]

mozregression --launch 2018-07-11 --pref privacy.trackingprotection.enabled:true startup.homepage_welcome_url:'https://bugzilla.mozilla.org/|about:buildconfig|https://www.startpage.com/'
1. Reload BMO, click X on the TP intro box.
2. Switch to about:buildconfig: It has a TP icon (bug).
3. Switch to StartPage and back to about:buildconfig: The TP icon is gone.
4. Switch to BMO and back to about:buildconfig: The TP icon is back.

In rarely cases BMO doesn't seem to have an active Google Analytics script(?), but mostly it has one (and even illegally in Germany if DNT:1 is sent: bug 1462851).

mozregression --good 2018-06-01 --bad 2018-07-11 --pref privacy.trackingprotection.enabled:true startup.homepage_welcome_url:'https://bugzilla.mozilla.org/|about:buildconfig|https://www.startpage.com/'
< 21:58.85 INFO: Last good revision: c1561409e431468169a6f22acaece537fe3de934
> 21:58.85 INFO: First bad revision: 6e0fc38940b484f165c4e76551d1bc91ded92ab7
> 21:58.85 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c1561409e431468169a6f22acaece537fe3de934&tochange=6e0fc38940b484f165c4e76551d1bc91ded92ab7

> 6e0fc38940b4	Johann Hofmann — Bug 1470020 - Part 4 - Don't handle Tracking Protection UI on file: and about: URIs. r=florian
> 00c94772a661	Johann Hofmann — Bug 1470020 - Part 3 - Updates to TP copy in the identity popup. r=florian
> 74475cd5a233	Johann Hofmann — Bug 1470020 - Part 2 - Add specific states for when the user has added a TP exception to the TP section of the identity popup. r=florian
> b7af8264a336	Johann Hofmann — Bug 1470020 - Part 1 - Don't show the "Enable Protection" button when it links to the TP preferences. r=florian

Side note: In general, thank you for polishing up tracking protection so nicely! :)

Comment 1

[Johann Hofmann [:johannh]]

Ah, thanks for catching this. This should affect all about: pages if I'm not mistaken. The fix should be easy and is already in bug 1471713 but we should make a separate upliftable patch in this bug as well...

Comment 2

[Johann Hofmann [:johannh]]

Attachment: Bug 1474891 - Reset tracking protection state when visiting about: pages.

Review commit: https://reviewboard.mozilla.org/r/256358/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256358/

Comment 3

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1a197ac1eb452e3ce55c998ae7dc6075761767f

Comment 4

[Erica Wright [:ewright]]

Comment on attachment 8991464 [details]
Bug 1474891 - Reset tracking protection state when visiting about: pages.

https://reviewboard.mozilla.org/r/256358/#review263406

thanks, it does what it's supposed to.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e71248ff093
Reset tracking protection state when visiting about: pages. r=ewright

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3e71248ff093

Comment 7

[Johann Hofmann [:johannh]]

Comment on attachment 8991464 [details]
Bug 1474891 - Reset tracking protection state when visiting about: pages.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1470020
[User impact if declined]: Visiting a page with tracking protection and after that an about: page will continue to show the TP shield
[Is this code covered by automated tests?]: Not this specific case, but the TP shield states are otherwise well covered.
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: With TP on, open a page with trackers then go to about:preferences in the same tab.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: One-liner that simply removes an attribute from an element that should not be applied.
[String changes made/needed]: None

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

darkspirit, since you found the issue, would you mind verifying this fix in nightly? Thanks!

Comment 9

[Darkspirit]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #0)
> mozregression --launch 2018-07-11 --pref privacy.trackingprotection.enabled:true startup.homepage_welcome_url:'https://bugzilla.mozilla.org/|about:buildconfig|https://www.startpage.com/'
> 1. Reload BMO, click X on the TP intro box.
> 2. Switch to about:buildconfig: It has a TP icon (bug).
> 3. Switch to StartPage and back to about:buildconfig: The TP icon is gone.
> 4. Switch to BMO and back to about:buildconfig: The TP icon is back.

mozregression --launch 2018-07-13 --pref privacy.trackingprotection.enabled:true startup.homepage_welcome_url:'https://bugzilla.mozilla.org/|about:buildconfig|https://www.startpage.com/'

Verified fixed on Windows 10 and Debian Testing. Thank you!

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8991464 [details]
Bug 1474891 - Reset tracking protection state when visiting about: pages.

Thanks very much! 
Fix verified by reporter, let's uplift this for beta 9.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/fb31b6425bf7