Closed Bug 1474900 Opened 6 years ago Closed 6 years ago

Assert there are no pending image lockers instead of wallpapering.

Categories

(Core :: Graphics: ImageLib, enhancement)

Product:
Core
Component:
Graphics: ImageLib
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox-esr52 --- wontfix
firefox-esr60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

(Keywords: sec-want, Whiteboard: [post-critsmash-triage][adv-main63-])

Attachments

(1 file, 1 obsolete file)

Actually passing try.
12.16 KB, patch
tnikkel
: review+
Details | Diff | Splinter Review 
It probably means that somebody still keeps a reference to us and has forgot about unlocking us, like bug 1473637.
er, people definitely leave locks around...
So my patch most definitely wouldn't pass try given it doesn't shut down the browser correctly locally :).

I still think we should have a way to crash safely if the image tracker leaves any stale reference around... I have a long flight where I'll try to take a look at whether it's trivial to make the lock / unlock calls match, or if there's any other way.
Group: core-security → gfx-core-security
Attachment #8991512 - Flags: review?(tnikkel) → review+
Daniel, do you know whether this can land without sec-approval or not?

This is mostly preventive action, but this will make some of the unexplained crashes with the signature of bug 1474900 safe.
Flags: needinfo?(dveditz)
Yes, you can check this in.
Flags: needinfo?(dveditz)
Keywords: sec-want
First patch missed some unit tests, and the XUL tree image cache.
Attachment #8991512 - Attachment is obsolete: true
Attachment #8997880 - Flags: review?(tnikkel)
Attachment #8997880 - Flags: review?(tnikkel) → review+
https://hg.mozilla.org/mozilla-central/rev/1efeecd0ac69
Group: gfx-core-security → core-security-release
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Emilio, is this something that should ride the trains?
Flags: needinfo?(emilio)
Yeah, I don't think we _need_ to uplift this, given the volume from the unknown crashes with the same signature as bug 1473637. 

Though I don't think it'd be terribly risky to do so...
Flags: needinfo?(emilio)
Agreed, let's leave well enough alone here.
status-firefox62: affected → wontfix
status-firefox-esr60: affected → wontfix
Flags: qe-verify-
Whiteboard: [post-critsmash-triage]
Whiteboard: [post-critsmash-triage] → [post-critsmash-triage][adv-main63-]
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: