Drop dom.animations-api.element-animate.enabled pref

RESOLVED FIXED in Firefox 63

Status

()

enhancement
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: birtles, Assigned: birtles)

Tracking

(Blocks 1 bug)

Trunk
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

11 months ago
We've been shipping this since Firefox 48. Although it's occasionally useful to have the pref to see how content behaves without Web Animations, it's not without cost and in particular it makes adding the more fine-grained prefs in bug 1471814 more complex.
Assignee

Comment 1

11 months ago
For my own reference, my analysis of all the tests using Web Animations prefs is here:

  https://docs.google.com/spreadsheets/d/1raQF-X4kauoOjQuzP8WJSZwSly6v__kn_xh61_xiX_0/edit?usp=sharing
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

11 months ago
mozreview-review
Comment on attachment 8991555 [details]
Bug 1475162 - Drop pref annotations from tests that no longer need them;

https://reviewboard.mozilla.org/r/256472/#review263352

Nice!

I did just audit files that the pref annotation were removed.  I haven't checked whether there are still tests that the pref can be removed or not.
Attachment #8991555 - Flags: review?(hikezoe) → review+

Comment 5

11 months ago
mozreview-review
Comment on attachment 8991554 [details]
Bug 1475162 - Drop dom.animations-api.element-animate.enabled pref;

https://reviewboard.mozilla.org/r/256470/#review263562
Attachment #8991554 - Flags: review?(bzbarsky) → review+

Comment 6

11 months ago
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00837a12b124
Drop dom.animations-api.element-animate.enabled pref; r=bz
https://hg.mozilla.org/integration/autoland/rev/a4cb46dfbdd7
Drop pref annotations from tests that no longer need them; r=hiro

Comment 7

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/00837a12b124
https://hg.mozilla.org/mozilla-central/rev/a4cb46dfbdd7
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.