1475177 - Change sendCommand xpcshell function to check for function objects

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P2)

Description

[Jan de Mooij [:jandem]]

It currently does |JS_TypeOfValue(cx, args[1]) != JSTYPE_FUNCTION| and CCWs and other proxies can also be JSTYPE_FUNCTION, but a MOZ_RELEASE_ASSERT + a Try push indicates we only pass plain, unwrapped functions.

So we could just check for function objects and then in TestShellCommandParent::RunCallback we can assert we have a JSFunction and we no longer have to worry about wrappers there.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Change sendCommand xpcshell function to only accept plain JSFunction callbacks

Comment 2

[Tom S. (please needinfo tschuster)]

Comment on attachment 8991551 [details] [diff] [review]
Change sendCommand xpcshell function to only accept plain JSFunction callbacks

Review of attachment 8991551 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, although I have never seen this code before

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb9cb191c067
Change sendCommand xpcshell function to only accept plain JSFunction callbacks. r=evilpie

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/bb9cb191c067