1475198 - Shift+Tab in JsTerm should give the focus to the previous element

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe][PTO - back January 2nd]]

At the moment, Shift + Tab doesn't do anything.
We should make it behave like a Shift Tab in a regular text input (focus previous element)
Check https://bugzilla.mozilla.org/show_bug.cgi?id=1472161#c16 to see more information about this decision.

Comment 1

[Nicolas Chevobbe [:nchevobbe][PTO - back January 2nd]]

We need to decide what to do for the codeMirror JsTerm in regard to this.
In codeMirror, shift tab will unindent current line/selected text, which is done in many text editors, and will probably be familiar to a lot of user. We could tab out only if the input is empty, like we do with Tab.

Comment 2

[Florens Verschelde :fvsch]

There is a similar problem in the Style Editor and in the Debugger. Once the focus is inside CodeMirror, there is no way back, only forward. :P

I was wondering what others do in this kind of situation. VS Code, for instance, does have the same kind of “Tab trapping” going on. So I looked at their accessibility documentation and they have two workarounds:

1. The global command palette lets users access any command or navigate between files, so they don’t have to tab through the full UI to get things done:
https://code.visualstudio.com/docs/editor/accessibility#_keyboard-navigation

2. They also have a keyboard shortcut for escaping tab trapping, documented here:
https://code.visualstudio.com/docs/editor/accessibility#_tab-trapping

Comment 3

[Nicolas Chevobbe [:nchevobbe][PTO - back January 2nd]]

Attachment: Bug 1475198 - Move focus to previous focusable element on Shift+Tab in JsTerm; r=yzen.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/539ff106cd84
Move focus to previous focusable element on Shift+Tab in JsTerm; r=yzen.

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/539ff106cd84