Size of Saved Logins box is no longer saved (Tools/Options/Privacy/Saved Logins)

VERIFIED FIXED in Firefox 62

Status

()

defect
--
minor
VERIFIED FIXED
10 months ago
9 months ago

People

(Reporter: alicechiappini, Assigned: bdahl)

Tracking

({regression})

62 Branch
mozilla63
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox61 unaffected, firefox62 verified, firefox63 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 months ago
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180709172241

Steps to reproduce:

FIREFOX 62 BETA 7. When I open options-privacy and security-saved access and enlarge the box with the saved passwords, the size chosen by me of the box is not stored but returns to the default size.


Actual results:

the size chosen by me of the box is not stored but returns to the default size when i open it again.


Expected results:

When I change the dimensions of the box I would like the new dimensions to be preserved

Comment 1

10 months ago
regression-window
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
20180712100120

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b830e5f05a78fad337911b36930a322bb82a81f1&tochange=49a11acd0acf4c3012d57ee45743412e236869ee
Blocks: 1453788
Severity: normal → minor
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → Preferences
Ever confirmed: true
Keywords: regression
Summary: Size of box SAVED ACCESS (Tools/Options/Privacy/saved access) is not saved → Size of Saved Logins box is no longer saved (Tools/Options/Privacy/Saved Logins)
Comment hidden (mozreview-request)
(Assignee)

Updated

10 months ago
Assignee: nobody → bdahl

Updated

9 months ago
Status: NEW → ASSIGNED

Updated

9 months ago
Component: Preferences → XUL
Product: Firefox → Core

Comment 3

9 months ago
mozreview-review
Comment on attachment 8991740 [details]
Bug 1475262 - Only ignore XUL persist on top level windows.

https://reviewboard.mozilla.org/r/256674/#review263848
Attachment #8991740 - Flags: review?(bugs) → review+
Neil, is this worth landing now, or waiting for bdahl to come back from PTO?
Flags: needinfo?(enndeakin)

Comment 5

9 months ago
This is fairly low risk so I think it could be checked in now.
Flags: needinfo?(enndeakin)
Thanks.
Keywords: checkin-needed

Comment 7

9 months ago
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10159cf474be
Only ignore XUL persist on top level windows. r=smaug
Keywords: checkin-needed

Comment 8

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/10159cf474be
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment hidden (obsolete)
(Reporter)

Comment 10

9 months ago
Sorry for my previous post. Could you find a FIX for FF 62 too? 
Best regards and thanks.
Alice
Comment on attachment 8991740 [details]
Bug 1475262 - Only ignore XUL persist on top level windows.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1453788, de-XUL project
[User impact if declined]: Users' previous preference subdialog window sizes will not be used
[Is this code covered by automated tests?]: The change didn't add tests
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: Maybe, seems like the reporter is confirming it's fixed in Nightly
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No, see comment 5
[Why is the change risky/not risky?]: straightforward change
[String changes made/needed]: None
Attachment #8991740 - Flags: approval-mozilla-beta?
Comment on attachment 8991740 [details]
Bug 1475262 - Only ignore XUL persist on top level windows.

Verified by reporter, let's uplift to beta. This should land for the beta 12 build.
Attachment #8991740 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
I have reproduced this bug using the STR from comment 0, on an affected Nightly build 2018-07-12.

I can confirm that the behavior described in this bug is verified as fixed on Beta 62.0b12 (20180726161819) and latest Nightly 63.0a1 (2018-07-26).
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Forgot to add the platforms tested: Windows 10 x64, macOS 10.12 and Ubuntu 16.04 x64.
(Reporter)

Comment 16

9 months ago
Hi. 
My feedback: just installed (on a PC with WINDOWS 10 HE 64 bit) the last FIREFOX, FF 62 BETA 12. The bug has been fixed and the problem I reported is no longer present.
Thanks.
Alice
You need to log in before you can comment on or make changes to this bug.