1475262 - Size of Saved Logins box is no longer saved (Tools/Options/Privacy/Saved Logins)

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[alice]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180709172241

Steps to reproduce:

FIREFOX 62 BETA 7. When I open options-privacy and security-saved access and enlarge the box with the saved passwords, the size chosen by me of the box is not stored but returns to the default size.


Actual results:

the size chosen by me of the box is not stored but returns to the default size when i open it again.


Expected results:

When I change the dimensions of the box I would like the new dimensions to be preserved

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
20180712100120

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b830e5f05a78fad337911b36930a322bb82a81f1&tochange=49a11acd0acf4c3012d57ee45743412e236869ee

Comment 2

[Brendan Dahl [:bdahl]]

Attachment: Bug 1475262 - Only ignore XUL persist on top level windows.

Fixes the incorrect assumption that all XUL <window> elements are top level
windows and will have their attribute persistence handled by the
nsXULWindow. An example of where this assumption fails is the password
manager which opens a <window> within a sub dialog that has no nsXULWindow.

Review commit: https://reviewboard.mozilla.org/r/256674/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256674/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8991740 [details]
Bug 1475262 - Only ignore XUL persist on top level windows.

https://reviewboard.mozilla.org/r/256674/#review263848

Comment 4

[Mike Taylor [:miketaylr]]

Neil, is this worth landing now, or waiting for bdahl to come back from PTO?

Comment 5

[Neil Deakin]

This is fairly low risk so I think it could be checked in now.

Comment 6

[Mike Taylor [:miketaylr]]

Thanks.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10159cf474be
Only ignore XUL persist on top level windows. r=smaug

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/10159cf474be

Comment 9

[alice]

Hi. I just upgraded Firefox to the 62 BETA 10 release. The problem -Size of Saved Logins box is no longer saved(Tools / Options / Privacy / Saved Logins)- is always present in my release and it has not been fixed as for FF 63. Could you find a FIX for FF 63 too?
Best regards.
Alice

Comment 10

[alice]

Sorry for my previous post. Could you find a FIX for FF 62 too? 
Best regards and thanks.
Alice

Comment 11

[Matthew N. [:MattN]]

Comment on attachment 8991740 [details]
Bug 1475262 - Only ignore XUL persist on top level windows.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1453788, de-XUL project
[User impact if declined]: Users' previous preference subdialog window sizes will not be used
[Is this code covered by automated tests?]: The change didn't add tests
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: Maybe, seems like the reporter is confirming it's fixed in Nightly
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No, see comment 5
[Why is the change risky/not risky?]: straightforward change
[String changes made/needed]: None

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8991740 [details]
Bug 1475262 - Only ignore XUL persist on top level windows.

Verified by reporter, let's uplift to beta. This should land for the beta 12 build.

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/558c190298cd

Comment 14

[Ciprian Georgiu, Desktop QA]

I have reproduced this bug using the STR from comment 0, on an affected Nightly build 2018-07-12.

I can confirm that the behavior described in this bug is verified as fixed on Beta 62.0b12 (20180726161819) and latest Nightly 63.0a1 (2018-07-26).

Comment 15

[Ciprian Georgiu, Desktop QA]

Forgot to add the platforms tested: Windows 10 x64, macOS 10.12 and Ubuntu 16.04 x64.

Comment 16

[alice]

Hi. 
My feedback: just installed (on a PC with WINDOWS 10 HE 64 bit) the last FIREFOX, FF 62 BETA 12. The bug has been fixed and the problem I reported is no longer present.
Thanks.
Alice