Closed Bug 1475278 Opened 6 years ago Closed 6 years ago

tup backend doesn't link rust host library into host binary (Perma-failure 'mach build -v' did not run successfully. Please check log for errors.)

Categories

(Firefox Build System :: General, defect, P5)

Product:
Firefox Build System
Component:
General
Type:
defect

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: chmanchester)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

bug 1475278 - don't use rust demangle in Breakpad when building with tup.
59 bytes, text/x-review-board-request
mshal
: review+
Details
Bug 1475278 - Link a HostRustLibrary to a HostProgram where necessary in the Tup backend.
59 bytes, text/x-review-board-request
mshal
: review+
Details 
Filed by: ccoroiu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=187835174&repo=autoland

https://queue.taskcluster.net/v1/task/dvXR_uAoQAeDysMfqYR2PQ/runs/1/artifacts/public/logs/live_backing.log

task 2018-07-12T13:59:27.289Z] 13:59:27     INFO -  *  97% 14229) obj-firefox/toolkit/crashreporter/google-breakpad/src/tools/linux/dump_syms: /builds/worker/workspace/build/src/gcc/bin/g++ -o ../../../../../../../dist/host/bin/dump_syms -D_GLIBCXX_USE_CXX11_ABI=0 -freorder-blocks -O2 -O2 -g /builds/worker/workspace/build/src/obj-firefox/toolkit/crashreporter/google-breakpad/src/tools/linux/dump_syms/host_dump_syms.o ../../../common/linux/libhost_breakpad_linux_common_s.a ../../../common/libhost_breakpad_common_s.a ../../../common/dwarf/libhost_breakpad_dwarf_s.a ../../../../../../../build/unix/stdc++compat/libhost_stdc++compat.a -ldl -lpthread -lrt
[task 2018-07-12T13:59:27.289Z] 13:59:27     INFO -  ../../../common/libhost_breakpad_common_s.a(host_language.o): In function `google_breakpad::RustLanguage::DemangleName(std::string const&, std::string*) const':
[task 2018-07-12T13:59:27.289Z] 13:59:27     INFO -  /builds/worker/workspace/build/src/toolkit/crashreporter/google-breakpad/src/common/language.cc:160: undefined reference to `rust_demangle'
[task 2018-07-12T13:59:27.289Z] 13:59:27     INFO -  /builds/worker/workspace/build/src/toolkit/crashreporter/google-breakpad/src/common/language.cc:165: undefined reference to `free_rust_demangled_name'
[task 2018-07-12T13:59:27.289Z] 13:59:27     INFO -  collect2: error: ld returned 1 exit status
[task 2018-07-12T13:59:27.289Z] 13:59:27     INFO -   *** tup errors ***
[task 2018-07-12T13:59:27.289Z] 13:59:27     INFO -   *** Command ID=343383 failed with return value 1
[task 2018-07-12T13:59:27.289Z] 13:59:27     INFO -  tup error: Expected to write to file '../../../../../../../dist/host/bin/dump_syms' from cmd 343383 but didn't
[task 2018-07-12T13:59:29.814Z] 13:59:29     INFO -   *** tup: 1 job failed.
[task 2018-07-12T13:59:32.131Z] 13:59:32     INFO -  357 compiler warnings present.
[task 2018-07-12T13:59:32.166Z] 13:59:32     INFO -  Notification center failed: Install notify-send (usually part of the libnotify package) to get a notification when the build finishes.
[task 2018-07-12T13:59:32.219Z] 13:59:32    ERROR - Return code: 1
[task 2018-07-12T13:59:32.219Z] 13:59:32  WARNING - setting return code to 2
[task 2018-07-12T13:59:32.219Z] 13:59:32    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2018-07-12T13:59:32.219Z] 13:59:32    FATAL - Running post_fatal callback...
[task 2018-07-12T13:59:32.219Z] 13:59:32    FATAL - Exiting -1
[task 2018-07-12T13:59:32.219Z] 13:59:32     INFO - [mozharness: 2018-07-12 13:59:32.219829Z] Finished build step (failed)
[task 2018-07-12T13:59:32.220Z] 13:59:32     INFO - Running post-run listener: _summarize
[task 2018-07-12T13:59:32.220Z] 13:59:32    ERROR - # TBPL FAILURE #
Assignee: nobody → ted
Blocks: 1474871
Flags: needinfo?(ted)
Comment on attachment 8991678 [details]
bug 1475278 - don't use rust demangle in Breakpad when building with tup.

https://reviewboard.mozilla.org/r/256610/#review263452

Works on my machine!
Attachment #8991678 - Flags: review?(mshal) → review+
I'm going to land this as a band-aid and keep this bug open to fix the underlying issue.
Flags: needinfo?(mh+mozilla)
Summary: Perma-failure 'mach build -v' did not run successfully. Please check log for errors. → tup backend doesn't link rust host library into host binary (Perma-failure 'mach build -v' did not run successfully. Please check log for errors.)
Pushed by tmielczarek@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2c5533f14f6
don't use rust demangle in Breakpad when building with tup. r=mshal
Btup is green again, but this is a hack:
https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=tup&selectedJob=187875316

We should figure out why the tup backend doesn't wind up linking the host Rust library properly.
I see the issue here.
Assignee: ted → cmanchester
Blocks: buildtup
Comment on attachment 8991775 [details]
Bug 1475278 - Link a HostRustLibrary to a HostProgram where necessary in the Tup backend.

https://reviewboard.mozilla.org/r/256694/#review264798
Attachment #8991775 - Flags: review+
Attachment #8991775 - Flags: review?(core-build-config-reviews)
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5f4d3179783
Link a HostRustLibrary to a HostProgram where necessary in the Tup backend. r=mshal
https://hg.mozilla.org/mozilla-central/rev/d5f4d3179783
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: