1475398 - Update "Firefox 63 uses schema version 52" comment in Database.cpp

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P1)

Description

[Drew Willcoxon :adw]

(In reply to Marco Bonardo [::mak] from bug 1467627 comment #37)
> (In reply to Drew Willcoxon :adw from comment #36)
> > (2) This patch is the one that landed on m-c except in Database.cpp I
> > changed the "Firefox 63 uses schema version 52" comment to say "Firefox 62"
> > since that seems like the right thing to do.  Do you agree?  If so, we
> > should change that comment on m-c too to match, right?
> 
> We should, and remove the double comment for Firefox 62, rs=me on doing that
> when it's the time.

Need to do this only after we actually uplift bug 1467627.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1475398 - Update "Firefox 63 uses schema version 52" comment in Database.cpp.

Review commit: https://reviewboard.mozilla.org/r/256690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256690/

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 8991760 [details]
Bug 1475398 - Update "Firefox 63 uses schema version 52" comment in Database.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256690/diff/1-2/

Comment 3

[Drew Willcoxon :adw]

Sorry, looks like mozreview/autoland don't recognize "rs=", so I changed the commit message to the usual "r?" (but again, I won't land this until bug 1467627 is uplifted)

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8991760 [details]
Bug 1475398 - Update "Firefox 63 uses schema version 52" comment in Database.cpp.

https://reviewboard.mozilla.org/r/256690/#review263618

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3719d445438c
Update "Firefox 63 uses schema version 52" comment in Database.cpp. r=mak

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3719d445438c