1475409 - Improve the clarity of nsXPTType and nsXPTTypeTag

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P3)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1475409 - Part 1: Remove nsXPTType::TagPart(), r=mccr8

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1475409 - Part 2: Be more explicit about the type of nsXPTType::Tag(), r=mccr8

Depends On D2113

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1475409 - Part 3: Make the different categories of types in xptinfo more explicit, r=mccr8

This should make it more clear which types have which behaviours, and should
make it easier to add new types without forgetting to handle a special case
somewhere.

Depends On D2114

Comment 4

[Phabricator Automation]

Comment on attachment 8991771 [details]
Bug 1475409 - Part 1: Remove nsXPTType::TagPart(), r=mccr8

Andrew McCreight [:mccr8] has approved the revision.

https://phabricator.services.mozilla.com/D2113

Comment 5

[Phabricator Automation]

Comment on attachment 8991772 [details]
Bug 1475409 - Part 2: Be more explicit about the type of nsXPTType::Tag(), r=mccr8

Andrew McCreight [:mccr8] has approved the revision.

https://phabricator.services.mozilla.com/D2114

Comment 6

[Phabricator Automation]

Comment on attachment 8991773 [details]
Bug 1475409 - Part 3: Make the different categories of types in xptinfo more explicit, r=mccr8

Andrew McCreight [:mccr8] has approved the revision.

https://phabricator.services.mozilla.com/D2115

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/850f21ca1f45
Part 1: Remove nsXPTType::TagPart(), r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/bddd838d1910
Part 2: Be more explicit about the type of nsXPTType::Tag(), r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f14f7b8bc3d
Part 3: Make the different categories of types in xptinfo more explicit, r=mccr8

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out 15 changesets (bug 1475409, bug 1461450, bug 1474369, bug 1471726) for build bustages on xptcstubs_gcc_x86_unix.cpp:55:1.

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/113e9ca0b5bccaf3eaee398e789f9b7b8c226009

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=79dbf5b9d8db577bba582a0853eb293d80eed0ba&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=190109107

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=190109107&repo=mozilla-inbound&lineNumber=12152

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c19ca740d3d1
Part 1: Remove nsXPTType::TagPart(), r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/39fcebfe6529
Part 2: Be more explicit about the type of nsXPTType::Tag(), r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/9817819b7765
Part 3: Make the different categories of types in xptinfo more explicit, r=mccr8

Comment 10

[Cosmin Sabou [:CosminS]]

Backed out for causing rooting hazards and browser chrome failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=Linux%20x64%20pgo%20Mochitests%20with%20e10s%20test-linux64-pgo%2Fopt-mochitest-browser-chrome-e10s-1%20M-e10s(bc1)&fromchange=7ce27aa3ce6887c226baa88223c0bf95bc2c3c28&tochange=e4f654755cc5cb80fb0a5a91707e8a2eff425e3e&selectedJob=190915193

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&fromchange=7ce27aa3ce6887c226baa88223c0bf95bc2c3c28&tochange=e4f654755cc5cb80fb0a5a91707e8a2eff425e3e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-classifiedState=unclassified&selectedJob=190903190&filter-searchStr=Linux%20x64%20debug%20hazard-linux64-haz%2Fdebug%20(H)

Failure log: 
browser chrome failures: https://treeherder.mozilla.org/logviewer.html#?job_id=190915193&repo=mozilla-inbound&lineNumber=3614
rooting hazards: https://treeherder.mozilla.org/logviewer.html#?job_id=190903190&repo=mozilla-inbound&lineNumber=47845

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/e4f654755cc5cb80fb0a5a91707e8a2eff425e3e

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6e6e87bbb6e
Part 1: Remove nsXPTType::TagPart(), r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/6137929f1671
Part 2: Be more explicit about the type of nsXPTType::Tag(), r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3c632a1500b
Part 3: Make the different categories of types in xptinfo more explicit, r=mccr8

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b6e6e87bbb6e
https://hg.mozilla.org/mozilla-central/rev/6137929f1671
https://hg.mozilla.org/mozilla-central/rev/f3c632a1500b