1475464 - Add more description about FunctionScope data

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Tooru Fujisawa [:arai]]

There are many kind of bindings in FunctionScope, and it's complicated.
we need some more description.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Add more description about FunctionScope data.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8991794 [details] [diff] [review]
Add more description about FunctionScope data.

Review of attachment 8991794 [details] [diff] [review]:
-----------------------------------------------------------------

That's useful, thanks!

::: js/src/vm/Scope.h
@@ +589,5 @@
>          //
> +        // Rest parameter binding is also included in positional formals.
> +        // This also becomes nullptr if destructuring.
> +        //
> +        // The number of positional formals equals to function.length if

Nit: s/equals to/is equal to/

@@ +593,5 @@
> +        // The number of positional formals equals to function.length if
> +        // there's no rest, function.length+1 otherwise.
> +        //
> +        // Destructuring parameters and destructuring rest are included in
> +        // other formals.

Nit: at first I didn't realize 'other formals' refers to the separate section mentioned below. Maybe s/other formals/"other formals"/ to avoid confusion.

Comment 3

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/738e3cb89b4b7513d69438da6a1b3f3748a34538
Bug 1475464 - Add more description about FunctionScope data. r=jandem DONTBUILD because comment only

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/738e3cb89b4b