1475489 - Folder dropdown section is unusable if it’s expanded again right after a New Folder was created inside the “New Bookmark” dialog

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Anca Soncutean, Desktop QA]

Attachment: screencat showing the issue.mov

[Affected versions]: 
- macOS 10.13
- Mac OS 10.11

[Affected platforms]:
- 63.0a1 (2018-07-12)
- 62.0b8 (20180712042337)
- 61.0.1 (20180704003137)

[Steps to reproduce]:
1. Bookmark any webpage via Star icon
2. Click on the "Show all the bookmarks folders" down arrow 
3. Click on the "New Folder" - [+] button (folder renaming is not necessary)
4. Click on the "Hide" up arrow 
5. Click again on the "Show all the bookmarks folders" down arrow 

[Expected result]:
- The Folder dropdown is successfully expanded, all the default folders and the one created at step 3 are displayed.

[Actual result]:
- The Folder dropdown is not usable anymore and only the text input-field of the folder created at step 3 is displayed. Any attempt to bookmark other web pages opens the same broken panel. This is fixed only after browser restart.

[Regression range]: 
- This is not a recent regression, I restrained the regression range only to to followings: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0e41d07a703f19224f60b01577b2cbb5708046c9&tochange=09a4282d1172ac255038e7ccacfd772140b219e2

[Additional Notes]:
- Make sure that after step 3 to not press the [Enter] key or click on the panel’s white space, in order to reproduce this behavior.
- Step 5 triggers the following error inside Browser console: see screenshot - 
https://drive.google.com/open?id=1kMUzgjKtczcmnOdp9BqUbj0VwDMfm7ML

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking as fix-optional since the team triaged it to a P3 and it's a regression from 2017.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1475489 - stop editing folder names when closing the folder tree in the edit bookmark panel, r?Standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a70847fa965
stop editing folder names when closing the folder tree in the edit bookmark panel, r=Standard8

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/3a70847fa965

Comment 6

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 62.0b8 on macOS 10.15.
I can confirm this issue is fixed, I verified using Firefox 84.0b4 on macOS 10.15.