1475501 - undoCloseTab calls addTab with bogus options object

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Dão Gottwald [:dao]]

undoCloseTab calls addTab with an internal "state" object, as the userContextId property happens to be set there. Aside from that the object only contains garbage as far as addTab is concerned, including a (history) index property that addTab will interpret differently.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1475501 - Clean up addTab call in undoCloseTab.

Review commit: https://reviewboard.mozilla.org/r/256714/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256714/

Comment 2

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [::dao] from comment #0)
> only contains garbage as far as addTab is concerned, including a (history)
> index property that addTab will interpret differently.

This was introduced in bug 1449700, btw.

Comment 3

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [::dao] from comment #0)
> undoCloseTab calls addTab with an internal "state" object, as the
> userContextId property happens to be set there.

pinned too...

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8991832 [details]
Bug 1475501 - Clean up addTab call in undoCloseTab.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256714/diff/1-2/

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 8991832 [details]
Bug 1475501 - Clean up addTab call in undoCloseTab.

https://reviewboard.mozilla.org/r/256714/#review264308

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17b9d8f5ca3a
Clean up addTab call in undoCloseTab. r=mikedeboer

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/17b9d8f5ca3a

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8991832 [details]
Bug 1475501 - Clean up addTab call in undoCloseTab.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1274461 and bug 1449700
[User impact if declined]: reopening a closed tab is inefficient as addTab will move the tab to a random location before it moves to the right place
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: /
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: straightforward cleanup, covered by tests
[String changes made/needed]: /

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8991832 [details]
Bug 1475501 - Clean up addTab call in undoCloseTab.

Fix for closed tabs in session restore, let's uplift for beta 11.

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/50ec48d931ba