Closed Bug 1475501 Opened 2 years ago Closed 2 years ago

undoCloseTab calls addTab with bogus options object

Categories

(Firefox :: Session Restore, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox-esr52 --- wontfix
firefox-esr60 --- wontfix
firefox61 --- wontfix
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(1 file)

undoCloseTab calls addTab with an internal "state" object, as the userContextId property happens to be set there. Aside from that the object only contains garbage as far as addTab is concerned, including a (history) index property that addTab will interpret differently.
(In reply to Dão Gottwald [::dao] from comment #0)
> only contains garbage as far as addTab is concerned, including a (history)
> index property that addTab will interpret differently.

This was introduced in bug 1449700, btw.
See Also: → 1449700
(In reply to Dão Gottwald [::dao] from comment #0)
> undoCloseTab calls addTab with an internal "state" object, as the
> userContextId property happens to be set there.

pinned too...
Comment on attachment 8991832 [details]
Bug 1475501 - Clean up addTab call in undoCloseTab.

https://reviewboard.mozilla.org/r/256714/#review264308
Attachment #8991832 - Flags: review?(mdeboer) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17b9d8f5ca3a
Clean up addTab call in undoCloseTab. r=mikedeboer
https://hg.mozilla.org/mozilla-central/rev/17b9d8f5ca3a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Flags: qe-verify-
Comment on attachment 8991832 [details]
Bug 1475501 - Clean up addTab call in undoCloseTab.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1274461 and bug 1449700
[User impact if declined]: reopening a closed tab is inefficient as addTab will move the tab to a random location before it moves to the right place
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: /
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: straightforward cleanup, covered by tests
[String changes made/needed]: /
Attachment #8991832 - Flags: approval-mozilla-beta?
Comment on attachment 8991832 [details]
Bug 1475501 - Clean up addTab call in undoCloseTab.

Fix for closed tabs in session restore, let's uplift for beta 11.
Attachment #8991832 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.