undoCloseTab calls addTab with bogus options object

RESOLVED FIXED in Firefox 62

Status

()

defect
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

({regression})

Trunk
Firefox 63
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox-esr52 wontfix, firefox-esr60 wontfix, firefox61 wontfix, firefox62 fixed, firefox63 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

11 months ago
undoCloseTab calls addTab with an internal "state" object, as the userContextId property happens to be set there. Aside from that the object only contains garbage as far as addTab is concerned, including a (history) index property that addTab will interpret differently.
Comment hidden (mozreview-request)
Assignee

Comment 2

11 months ago
(In reply to Dão Gottwald [::dao] from comment #0)
> only contains garbage as far as addTab is concerned, including a (history)
> index property that addTab will interpret differently.

This was introduced in bug 1449700, btw.
See Also: → 1449700
Assignee

Comment 3

11 months ago
(In reply to Dão Gottwald [::dao] from comment #0)
> undoCloseTab calls addTab with an internal "state" object, as the
> userContextId property happens to be set there.

pinned too...
Comment hidden (mozreview-request)

Comment 5

11 months ago
mozreview-review
Comment on attachment 8991832 [details]
Bug 1475501 - Clean up addTab call in undoCloseTab.

https://reviewboard.mozilla.org/r/256714/#review264308
Attachment #8991832 - Flags: review?(mdeboer) → review+

Comment 6

11 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17b9d8f5ca3a
Clean up addTab call in undoCloseTab. r=mikedeboer

Comment 7

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/17b9d8f5ca3a
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Assignee

Updated

11 months ago
Flags: qe-verify-
Assignee

Comment 8

11 months ago
Comment on attachment 8991832 [details]
Bug 1475501 - Clean up addTab call in undoCloseTab.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1274461 and bug 1449700
[User impact if declined]: reopening a closed tab is inefficient as addTab will move the tab to a random location before it moves to the right place
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: /
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: straightforward cleanup, covered by tests
[String changes made/needed]: /
Attachment #8991832 - Flags: approval-mozilla-beta?
Keywords: regression
Comment on attachment 8991832 [details]
Bug 1475501 - Clean up addTab call in undoCloseTab.

Fix for closed tabs in session restore, let's uplift for beta 11.
Attachment #8991832 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.