1475521 - Payments shouldn't be processed without selecting a shipping address

Status: VERIFIED FIXED

(Firefox :: WebPayments UI, defect, P1)

Description

[Hani Yacoub, Desktop QA]

[Affected versions]: 
Nightly 63.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.13 and Ubuntu 17.04 x64.

[Preconditions]:
1. Set the pref dom.payments.request.enabled to "true";
2. Set the pref dom.payments.loglevel to “Debug” to increase the verbosity of console messages.
3. Make sure you have at least one Shipping Address and one Shipping Option saved in your browser (Saved Cards).

[Steps to reproduce]:
1. Go to "https://rsolomakhin.github.io/pr/us/" page and click on "Buy".
2. From "Payment method" page select payment method without selecting a shipping address and click on "Pay".

[Expected result]:
Payments shouldn't be proceed without selecting a shipping option.

[Actual result]:
Payment is proceed and the response is correctly displayed and filling with the correct data entered before.

Comment 2

[Peter Saint-Andre [:stpeter]]

Not all payments are for items that can be shipped (e.g., digital goods), but perhaps this bug report already takes that into account...

Comment 3

[Matthew N. [:MattN]]

Yeah, this is for when the shipping picker is shown.

Comment 4

[Matthew N. [:MattN]]

If possible, please try to handle this for all of the pickers on the summary page since it's possible for any of them to be empty.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1475521 - Payments shouldn't be processed without selecting a shipping address.

Review commit: https://reviewboard.mozilla.org/r/260062/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260062/

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 8995671 [details]
Bug 1475521 - Payments shouldn't be processed without selecting a shipping address.

https://reviewboard.mozilla.org/r/260062/#review267102

::: browser/components/payments/res/containers/payment-dialog.js:235
(Diff revision 1)
> +    if (completeStatus == "") {
> +      completeStatus = "initial";
> +    }
> +
>      switch (completeStatus) {
>        case "initial":

Hmm… not sure if you need to rebase or what but I removed the "intiial" state and instead we use "".

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8995671 [details]
Bug 1475521 - Payments shouldn't be processed without selecting a shipping address.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260062/diff/1-2/

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8995671 [details]
Bug 1475521 - Payments shouldn't be processed without selecting a shipping address.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260062/diff/2-3/

Comment 9

[Matthew N. [:MattN]]

Comment on attachment 8995671 [details]
Bug 1475521 - Payments shouldn't be processed without selecting a shipping address.

https://reviewboard.mozilla.org/r/260062/#review267144

::: browser/components/payments/res/containers/payment-dialog.js:247
(Diff revision 3)
> -      case "": // initial/default state
> +      case "": {
> +        // initial/default state
> +        this._payButton.textContent = this._payButton.dataset.label;
> +        this._payButton.disabled =
> +          (state.request.paymentOptions.requestShipping &&
> +           (!this._shippingAddressPicker.dropdown.selectedOption ||

Nit: I would rather use picker.value so that this code doesn't rely on the implementation details of pickers.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8995671 [details]
Bug 1475521 - Payments shouldn't be processed without selecting a shipping address.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260062/diff/3-4/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3147045b0b5
Payments shouldn't be processed without selecting a shipping address. r=MattN

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f3147045b0b5

Comment 13

[Timea Cernea [:tbabos][inactive]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Verified fixed on the latest Nightly version 63.0a1 (2018-07-30) on Windows 10, Mac 10.13, Ubuntu 16.04.
The "Pay" button is grayed out if a shipping address is not selected, thus the payment cannot be processed.