1475537 - Clean up addTab parameter handling

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P1)

Description

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a361122f026d077a918760fcff94b2461ea47ed9

I had to remove "use strict" because of this: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Strict_Non_Simple_Params

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1475537 - Clean up addTab parameter handling.

Review commit: https://reviewboard.mozilla.org/r/256824/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256824/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8991904 [details]
Bug 1475537 - Clean up addTab parameter handling.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256824/diff/1-2/

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8991904 [details]
Bug 1475537 - Clean up addTab parameter handling.

https://reviewboard.mozilla.org/r/256824/#review264314

This is like a breath of fresh air! Very nice.

If you're going to use trailing-comma all the way, you might want to consider enabling the appropriate eslint rule for this file.

::: browser/base/content/tabbrowser.js:2340
(Diff revision 2)
>            uriIsAboutBlank,
> -          userContextId: aUserContextId,
> -          sameProcessAsFrameLoader: aSameProcessAsFrameLoader,
> -          openerWindow: aOpener,
> -          nextTabParentId: aNextTabParentId,
> -          name: aName
> +          userContextId,
> +          sameProcessAsFrameLoader,
> +          openerWindow: opener,
> +          nextTabParentId,
> +          name,

nit: Is a trailing comma at the end of an object literal a thing in tabbrowser? I don't like the style, tbh, smells too much like cargo culting to me.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d9cd6db7f77
Clean up addTab parameter handling. r=mikedeboer

Comment 5

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 1d9cd6db7f77 (bug 1475537) for devtools failures at devtools/client/netmonitor/test/browser_net_open_request_in_tab.js

Backout: https://hg.mozilla.org/integration/autoland/rev/50fc7211e1964c7cc21a2e5d97b6f8cd95bb0b24

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1d9cd6db7f77460763e36b38cc9269bdabac5675&selectedJob=188529758

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=188529758&repo=autoland&lineNumber=6196

task 2018-07-17T10:08:45.815Z] 10:08:45     INFO - TEST-START | devtools/client/netmonitor/test/browser_net_open_request_in_tab.js
[task 2018-07-17T10:08:45.860Z] 10:08:45     INFO - GECKO(1812) | ++DOCSHELL 0x7f686aeaa000 == 2 [pid = 1969] [id = {c306e271-fba8-4c46-8b5a-35029631eac8}]
[task 2018-07-17T10:08:45.860Z] 10:08:45     INFO - GECKO(1812) | ++DOMWINDOW == 3 (0x7f68704fa800) [pid = 1969] [serial = 211] [outer = (nil)]
[task 2018-07-17T10:08:45.982Z] 10:08:45     INFO - GECKO(1812) | ++DOMWINDOW == 4 (0x7f686aedc800) [pid = 1969] [serial = 212] [outer = 0x7f68704fa800]
[task 2018-07-17T10:08:47.795Z] 10:08:47     INFO - GECKO(1812) | --DOMWINDOW == 3 (0x7fe6a324e200) [pid = 1911] [serial = 70] [outer = (nil)] [url = about:blank]
[task 2018-07-17T10:08:48.422Z] 10:08:48     INFO - GECKO(1812) | --DOMWINDOW == 29 (0x7f7d0d9eb800) [pid = 1812] [serial = 303] [outer = (nil)] [url = about:config]
[task 2018-07-17T10:08:48.423Z] 10:08:48     INFO - GECKO(1812) | --DOMWINDOW == 28 (0x7f7d27a52000) [pid = 1812] [serial = 308] [outer = (nil)] [url = about:blank]
[task 2018-07-17T10:08:48.425Z] 10:08:48     INFO - GECKO(1812) | --DOMWINDOW == 27 (0x7f7d23c10000) [pid = 1812] [serial = 306] [outer = (nil)] [url = about:devtools-toolbox]
[task 2018-07-17T10:08:48.426Z] 10:08:48     INFO - GECKO(1812) | --DOMWINDOW == 26 (0x7f7d0d9ec000) [pid = 1812] [serial = 305] [outer = (nil)] [url = about:blank]
[task 2018-07-17T10:08:48.428Z] 10:08:48     INFO - GECKO(1812) | --DOCSHELL 0x7f7d0e212000 == 8 [pid = 1812] [id = {194d5b92-7139-48c6-8b70-ca610f378338}]
[task 2018-07-17T10:08:48.429Z] 10:08:48     INFO - GECKO(1812) | --DOCSHELL 0x7f7d0e6b4800 == 7 [pid = 1812] [id = {bd471fa2-fd2c-4b2c-a9e3-07c1d23a568e}]
[task 2018-07-17T10:08:48.438Z] 10:08:48     INFO - GECKO(1812) | --DOCSHELL 0x7f7d1b11e000 == 6 [pid = 1812] [id = {41b43329-8309-4a88-b4b2-b2ba6c296fb6}]
[task 2018-07-17T10:08:49.042Z] 10:08:49     INFO - GECKO(1812) | [Parent 1812, Main Thread] WARNING: NS_ENSURE_TRUE(currentInner) failed: file /builds/worker/workspace/build/src/dom/base/WindowDestroyedEvent.cpp, line 110
[task 2018-07-17T10:08:49.056Z] 10:08:49     INFO - GECKO(1812) | --DOMWINDOW == 25 (0x7f7d30e05200) [pid = 1812] [serial = 321] [outer = (nil)] [url = chrome://devtools/content/styleeditor/index.xul]
[task 2018-07-17T10:08:49.060Z] 10:08:49     INFO - GECKO(1812) | --DOMWINDOW == 24 (0x7f7d184cec00) [pid = 1812] [serial = 312] [outer = (nil)] [url = chrome://devtools/content/netmonitor/index.html]
[task 2018-07-17T10:08:49.064Z] 10:08:49     INFO - GECKO(1812) | --DOMWINDOW == 23 (0x7f7d184cd000) [pid = 1812] [serial = 309] [outer = (nil)] [url = about:devtools-toolbox]
[task 2018-07-17T10:08:49.066Z] 10:08:49     INFO - GECKO(1812) | --DOMWINDOW == 22 (0x7f7d30e06000) [pid = 1812] [serial = 314] [outer = (nil)] [url = chrome://devtools/content/debugger/new/index.html]
[task 2018-07-17T10:08:49.190Z] 10:08:49     INFO - GECKO(1812) | ++DOMWINDOW == 5 (0x7f68704a3400) [pid = 1969] [serial = 213] [outer = 0x7f68704fa800]
[task 2018-07-17T10:08:49.713Z] 10:08:49     INFO - GECKO(1812) | ++DOCSHELL 0x7f7d0e217000 == 7 [pid = 1812] [id = {7746b187-c919-4048-bfd9-326b8409b980}]
[task 2018-07-17T10:08:49.715Z] 10:08:49     INFO - GECKO(1812) | ++DOMWINDOW == 23 (0x7f7d184cfe00) [pid = 1812] [serial = 323] [outer = (nil)]
[task 2018-07-17T10:08:49.718Z] 10:08:49     INFO - GECKO(1812) | ++DOMWINDOW == 24 (0x7f7d0d9ea400) [pid = 1812] [serial = 324] [outer = 0x7f7d184cfe00]
[task 2018-07-17T10:08:49.842Z] 10:08:49     INFO - GECKO(1812) | ++DOMWINDOW == 25 (0x7f7d0e6a0000) [pid = 1812] [serial = 325] [outer = 0x7f7d184cfe00]
[task 2018-07-17T10:08:50.309Z] 10:08:50     INFO - GECKO(1812) | --DOMWINDOW == 2 (0x7fe69fcb5000) [pid = 1911] [serial = 71] [outer = (nil)] [url = about:blank]
[task 2018-07-17T10:08:50.386Z] 10:08:50     INFO - GECKO(1812) | ++DOCSHELL 0x7f7d0e6b4800 == 8 [pid = 1812] [id = {646d79af-c3c5-420f-928d-89e3d6669d5c}]
[task 2018-07-17T10:08:50.387Z] 10:08:50     INFO - GECKO(1812) | ++DOMWINDOW == 26 (0x7f7d184cd400) [pid = 1812] [serial = 326] [outer = (nil)]
[task 2018-07-17T10:08:50.387Z] 10:08:50     INFO - GECKO(1812) | ++DOMWINDOW == 27 (0x7f7d0e69e400) [pid = 1812] [serial = 327] [outer = 0x7f7d184cd400]
[task 2018-07-17T10:08:53.090Z] 10:08:53     INFO - GECKO(1812) | --DOCSHELL 0x7eff5b1ef800 == 0 [pid = 1944] [id = {6cdd9818-1ded-4567-b704-0389a0a3b71d}]
[task 2018-07-17T10:08:53.336Z] 10:08:53     INFO - GECKO(1812) | ++DOMWINDOW == 6 (0x7f686aed8800) [pid = 1969] [serial = 214] [outer = 0x7f68704fa800]
[task 2018-07-17T10:08:53.711Z] 10:08:53     INFO - GECKO(1812) | --DOMWINDOW == 1 (0x7eff5d50be00) [pid = 1944] [serial = 78] [outer = (nil)] [url = about:blank]
[task 2018-07-17T10:08:54.111Z] 10:08:54     INFO - GECKO(1812) | --DOCSHELL 0x7f686aea1800 == 1 [pid = 1969] [id = {cf450450-4e6d-4c43-9836-99a306ff86bd}]
[task 2018-07-17T10:08:54.453Z] 10:08:54     INFO - GECKO(1812) | --DOMWINDOW == 5 (0x7f686aeec200) [pid = 1969] [serial = 207] [outer = (nil)] [url = http://example.com/browser/devtools/client/netmonitor/test/html_content-type-without-cache-test-page.html]
[task 2018-07-17T10:08:57.187Z] 10:08:57     INFO - GECKO(1812) | JavaScript error: chrome://browser/content/tabbrowser.js, line 2145: TypeError: null has no properties
[task 2018-07-17T10:08:57.550Z] 10:08:57     INFO - GECKO(1812) | --DOMWINDOW == 0 (0x7eff5d557000) [pid = 1944] [serial = 79] [outer = (nil)] [url = about:blank]
[task 2018-07-17T10:08:58.338Z] 10:08:58     INFO - GECKO(1812) | --DOMWINDOW == 4 (0x7f68704a3400) [pid = 1969] [serial = 213] [outer = (nil)] [url = http://example.com/browser/devtools/client/netmonitor/test/html_open-request-in-tab.html]
[task 2018-07-17T10:08:58.339Z] 10:08:58     INFO - GECKO(1812) | --DOMWINDOW == 3 (0x7f686aedc800) [pid = 1969] [serial = 212] [outer = (nil)] [url = about:blank]
[task 2018-07-17T10:08:58.340Z] 10:08:58     INFO - GECKO(1812) | --DOMWINDOW == 2 (0x7f686aede000) [pid = 1969] [serial = 210] [outer = (nil)] [url = http://example.com/browser/devtools/client/netmonitor/test/html_content-type-without-cache-test-page.html]
[task 2018-07-17T10:08:58.705Z] 10:08:58     INFO - GECKO(1812) | --DOMWINDOW == 26 (0x7f7d0e2f4400) [pid = 1812] [serial = 313] [outer = (nil)] [url = about:blank]
[task 2018-07-17T10:08:58.706Z] 10:08:58     INFO - GECKO(1812) | --DOMWINDOW == 25 (0x7f7d3ddaa400) [pid = 1812] [serial = 322] [outer = (nil)] [url = about:blank]
[task 2018-07-17T10:08:58.707Z] 10:08:58     INFO - GECKO(1812) | --DOMWINDOW == 24 (0x7f7d0e6ac000) [pid = 1812] [serial = 315] [outer = (nil)] [url = about:blank]
[task 2018-07-17T10:08:58.708Z] 10:08:58     INFO - GECKO(1812) | --DOMWINDOW == 23 (0x7f7d0e2f6c00) [pid = 1812] [serial = 311] [outer = (nil)] [url = about:devtools-toolbox]
[task 2018-07-17T10:08:58.709Z] 10:08:58     INFO - GECKO(1812) | --DOMWINDOW == 22 (0x7f7d0d9f5400) [pid = 1812] [serial = 310] [outer = (nil)] [url = about:blank]
[task 2018-07-17T10:08:59.875Z] 10:08:59     INFO - GECKO(1812) | --DOMWINDOW == 21 (0x7f7d184cfc00) [pid = 1812] [serial = 316] [outer = (nil)] [url = about:devtools-toolbox]
[task 2018-07-17T10:08:59.876Z] 10:08:59     INFO - GECKO(1812) | --DOMWINDOW == 20 (0x7f7d184d0600) [pid = 1812] [serial = 319] [outer = (nil)] [url = chrome://devtools/content/netmonitor/index.html]
[task 2018-07-17T10:09:09.653Z] 10:09:09     INFO - GECKO(1812) | --DOMWINDOW == 19 (0x7f7d0e6a7c00) [pid = 1812] [serial = 318] [outer = (nil)] [url = about:devtools-toolbox]
[task 2018-07-17T10:09:09.654Z] 10:09:09     INFO - GECKO(1812) | --DOMWINDOW == 18 (0x7f7d17fa3800) [pid = 1812] [serial = 320] [outer = (nil)] [url = about:blank]
[task 2018-07-17T10:09:09.656Z] 10:09:09     INFO - GECKO(1812) | --DOMWINDOW == 17 (0x7f7d0d9f6000) [pid = 1812] [serial = 317] [outer = (nil)] [url = about:blank]
[task 2018-07-17T10:10:16.049Z] 10:10:16     INFO - TEST-INFO | started process screentopng
[task 2018-07-17T10:10:16.581Z] 10:10:16     INFO - TEST-INFO | screentopng: exit 0
[task 2018-07-17T10:10:16.581Z] 10:10:16     INFO - Buffered messages logged at 10:08:45
[task 2018-07-17T10:10:16.581Z] 10:10:16     INFO - Entering test bound 
[task 2018-07-17T10:10:16.581Z] 10:10:16     INFO - Initializing a network monitor pane.
[task 2018-07-17T10:10:16.582Z] 10:10:16     INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/netmonitor/test/html_open-request-in-tab.html
[task 2018-07-17T10:10:16.582Z] 10:10:16     INFO - Buffered messages logged at 10:08:49
[task 2018-07-17T10:10:16.582Z] 10:10:16     INFO - Tab added and finished loading
[task 2018-07-17T10:10:16.583Z] 10:10:16     INFO - Net tab added successfully: http://example.com/browser/devtools/client/netmonitor/test/html_open-request-in-tab.html
[task 2018-07-17T10:10:16.585Z] 10:10:16     INFO - Target remoted.
[task 2018-07-17T10:10:16.587Z] 10:10:16     INFO - Buffered messages logged at 10:08:51
[task 2018-07-17T10:10:16.589Z] 10:10:16     INFO - Network monitor pane shown successfully.
[task 2018-07-17T10:10:16.591Z] 10:10:16     INFO - Disabling cache and reloading page.
[task 2018-07-17T10:10:16.593Z] 10:10:16     INFO - Buffered messages logged at 10:08:53
[task 2018-07-17T10:10:16.594Z] 10:10:16     INFO - Request server1.conn56.child1/netEvent25 for http://example.com/browser/devtools/client/netmonitor/test/html_open-request-in-tab.html not yet done, keep waiting...
[task 2018-07-17T10:10:16.596Z] 10:10:16     INFO - Buffered messages logged at 10:08:54
[task 2018-07-17T10:10:16.598Z] 10:10:16     INFO - Got marker: dom-interactive
[task 2018-07-17T10:10:16.600Z] 10:10:16     INFO - Got marker: dom-complete
[task 2018-07-17T10:10:16.601Z] 10:10:16     INFO - Got two timeline markers, done waiting
[task 2018-07-17T10:10:16.602Z] 10:10:16     INFO - Request server1.conn56.child1/netEvent25 for http://example.com/browser/devtools/client/netmonitor/test/html_open-request-in-tab.html done
[task 2018-07-17T10:10:16.604Z] 10:10:16     INFO - All requests finished
[task 2018-07-17T10:10:16.606Z] 10:10:16     INFO - Cache disabled when the current and all future toolboxes are open.
[task 2018-07-17T10:10:16.607Z] 10:10:16     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_open_request_in_tab.js | Request to reconfigure the tab was recorded. - 
[task 2018-07-17T10:10:16.609Z] 10:10:16     INFO - Clearing requests in the console client.
[task 2018-07-17T10:10:16.610Z] 10:10:16     INFO - Clearing requests in the UI.
[task 2018-07-17T10:10:16.611Z] 10:10:16     INFO - Buffered messages logged at 10:08:55
[task 2018-07-17T10:10:16.612Z] 10:10:16     INFO - Starting test...
[task 2018-07-17T10:10:16.613Z] 10:10:16     INFO - > Network event progress: NetworkEvent: 1/1, PayloadReady: 0/1, got NetMonitor:NetworkEvent for server1.conn56.child1/netEvent45
[task 2018-07-17T10:10:16.614Z] 10:10:16     INFO - > Network event progress: NetworkEvent: 1/1, PayloadReady: 1/1, got NetMonitor:PayloadReady for server1.conn56.child1/netEvent45
[task 2018-07-17T10:10:16.614Z] 10:10:16     INFO - Buffered messages logged at 10:08:56
[task 2018-07-17T10:10:16.615Z] 10:10:16     INFO - Waiting for event: 'TabOpen' on [object XULElement].
[task 2018-07-17T10:10:16.616Z] 10:10:16     INFO - Buffered messages logged at 10:08:57
[task 2018-07-17T10:10:16.617Z] 10:10:16     INFO - Console message: [JavaScript Error: "TypeError: null has no properties" {file: "chrome://browser/content/tabbrowser.js" line: 2145}]
[task 2018-07-17T10:10:16.618Z] 10:10:16     INFO - Buffered messages finished
[task 2018-07-17T10:10:16.619Z] 10:10:16     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_open_request_in_tab.js | Test timed out - 
[task 2018-07-17T10:10:16.619Z] 10:10:16     INFO - GECKO(1812) | ++DOMWINDOW == 18 (0x7f7d0e6a0c00) [pid = 1812] [serial = 328] [outer = 0x7f7d184cfe00]
[task 2018-07-17T10:10:17.710Z] 10:10:17     INFO - GECKO(1812) | --DOCSHELL 0x7f7d0e6b4800 == 7 [pid = 1812] [id = {646d79af-c3c5-420f-928d-89e3d6669d5c}]
[task 2018-07-17T10:10:17.713Z] 10:10:17     INFO - GECKO(1812) | --DOCSHELL 0x7f7d0e217000 == 6 [pid = 1812] [id = {7746b187-c919-4048-bfd9-326b8409b980}]
[task 2018-07-17T10:10:17.730Z] 10:10:17     INFO - Removing tab.
[task 2018-07-17T10:10:17.732Z] 10:10:17     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2018-07-17T10:10:17.793Z] 10:10:17     INFO - Got event: 'TabClose' on [object XULElement].
[task 2018-07-17T10:10:17.818Z] 10:10:17     INFO - Tab removed and finished closing
[task 2018-07-17T10:10:17.820Z] 10:10:17     INFO - finish() was called, cleaning up...
[task 2018-07-17T10:10:17.901Z] 10:10:17     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-07-17T10:10:17.901Z] 10:10:17     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_open_request_in_tab.js | A promise chain failed to handle a rejection: null has no properties - stack: addTab@chrome://browser/content/tabbrowser.js:2145:1
[task 2018-07-17T10:10:17.902Z] 10:10:17     INFO - openRequestInTab@resource://devtools/shared/base-loader.js -> resource://devtools/client/netmonitor/src/utils/firefox/open-request-in-tab.js:37:30

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8991904 [details]
Bug 1475537 - Clean up addTab parameter handling.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256824/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ecba96062515
Clean up addTab parameter handling. r=mikedeboer

Comment 8

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/ecba96062515