Use llvm-lib as AR when linking with lld-link

RESOLVED FIXED in Firefox 63

Status

enhancement
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: dmajor, Assigned: dmajor)

Tracking

Trunk
mozilla63
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

11 months ago
Building with ThinLTO requires that we use llvm-lib.exe as $(AR) because Microsoft's lib.exe doesn't understand the file format.

Without LTO, it's entirely possible to mix and match LLVM and MS's programs, but for simplicity let's just say we'll always use lld-link and llvm-lib together.

As a bonus, we can use -llvmlibthin to generate thin libraries, which store pointers to the original obj files rather than copy the data. As long as we don't need to ship or share the libs (which we don't) this can save us some work.
Assignee

Comment 1

11 months ago
Posted patch llvm-libSplinter Review
Assignee: nobody → dmajor
Attachment #8992010 - Flags: review?(core-build-config-reviews)
Attachment #8992010 - Flags: review?(core-build-config-reviews) → review+

Comment 2

11 months ago
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/79c65f8a1a07
Use llvm-lib when linking with lld-link. r=froydnj

Comment 3

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/79c65f8a1a07
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.