1475707 - [Mac] Flash sandbox on Nightly/Beta causes OS X 10.9 file upload dialog Flash plugin crash

Status: VERIFIED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Haik Aftandilian [:haik]]

On OS X 10.9, with the latest Nightly which has the Mac Flash sandbox enabled, attempting to upload a file using a demo uploader[1] results in the Flash plugin crashing.

This will also affect Beta builds that have Flash sandbox level set to 1 or above via pref "dom.ipc.plugins.sandbox-level.flash". Some early builds of Beta have the Flash sandbox on by default.

Release builds are not affected.

Workaround:
In about:config, set the preference "dom.ipc.plugins.sandbox-level.flash" to 0 and restart the browser. If the pref is not present, the sandbox is not enabled.

1. http://www.tinywebgallery.com/en/tfu/web_demo1.php

Comment 1

[Haik Aftandilian [:haik]]

Attachment: Bug 1475707 - [Mac] Flash sandbox on Nightly/Beta causes OS X 10.9 file upload dialog Flash plugin crash

Add services needed by OS X 10.9 to display file dialogs without crashing from the Flash plugin process.

Review commit: https://reviewboard.mozilla.org/r/256996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256996/

Comment 2

[Haik Aftandilian [:haik]]

Comment on attachment 8992104 [details]
Bug 1475707 - [Mac] Flash sandbox on Nightly/Beta causes OS X 10.9 file upload dialog Flash plugin crash

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256996/diff/1-2/

Comment 3

[Alex Gaynor [:Alex_Gaynor]]

Comment on attachment 8992104 [details]
Bug 1475707 - [Mac] Flash sandbox on Nightly/Beta causes OS X 10.9 file upload dialog Flash plugin crash

https://reviewboard.mozilla.org/r/256996/#review263996

Comment 4

[Haik Aftandilian [:haik]]

Comment on attachment 8992104 [details]
Bug 1475707 - [Mac] Flash sandbox on Nightly/Beta causes OS X 10.9 file upload dialog Flash plugin crash

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/256996/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/519aebccf07d
[Mac] Flash sandbox on Nightly/Beta causes OS X 10.9 file upload dialog Flash plugin crash r=Alex_Gaynor

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/519aebccf07d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 8

[Haik Aftandilian [:haik]]

I've requested uplift of bug 1474375 and listed this bug as a dependency.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8992104 [details]
Bug 1475707 - [Mac] Flash sandbox on Nightly/Beta causes OS X 10.9 file upload dialog Flash plugin crash

Approval Request Comment
[Feature/Bug causing the regression]: required for bug 1474375 
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

STR in comment 0. I'd like us to verify the fixes in nightly for Bug 1475722, Bug 1471977, and Bug 1475707 before we uplift for beta. (Hopefully for beta 13 next Monday)

Comment 11

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Nightly (2018-07-13) on Mac OS 10.9. As soon as the dialog box was displayed the Flash plugin crashed. 
I retested using the latest Nightly 63.0a1 and the bug is not reproducing anymore.

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8992104 [details]
Bug 1475707 - [Mac] Flash sandbox on Nightly/Beta causes OS X 10.9 file upload dialog Flash plugin crash

Fix was verified on Nightly63, Beta62+

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a44407cbf3db

Comment 14

[Bogdan Maris, Desktop QA]

Readding qe-verify+ to make sure beta 14 is also verified.

Comment 15

[Oana Botisan, Desktop QA]

I verified the fix on beta 62.0b14 using Mac OS 10.9 and the plugin is not crashing anymore.