Closed Bug 1475707 Opened Last year Closed Last year

[Mac] Flash sandbox on Nightly/Beta causes OS X 10.9 file upload dialog Flash plugin crash

Categories

(Core :: Security: Process Sandboxing, defect, P1)

62 Branch
Unspecified
macOS
defect

Tracking

()

VERIFIED FIXED
mozilla63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- disabled
firefox62 --- verified
firefox63 --- verified

People

(Reporter: haik, Assigned: haik)

References

Details

(Keywords: regression)

Attachments

(1 file)

On OS X 10.9, with the latest Nightly which has the Mac Flash sandbox enabled, attempting to upload a file using a demo uploader[1] results in the Flash plugin crashing.

This will also affect Beta builds that have Flash sandbox level set to 1 or above via pref "dom.ipc.plugins.sandbox-level.flash". Some early builds of Beta have the Flash sandbox on by default.

Release builds are not affected.

Workaround:
In about:config, set the preference "dom.ipc.plugins.sandbox-level.flash" to 0 and restart the browser. If the pref is not present, the sandbox is not enabled.

1. http://www.tinywebgallery.com/en/tfu/web_demo1.php
Assignee: nobody → haftandilian
Blocks: 1474375
Priority: -- → P1
Comment on attachment 8992104 [details]
Bug 1475707 - [Mac] Flash sandbox on Nightly/Beta causes OS X 10.9 file upload dialog Flash plugin crash

https://reviewboard.mozilla.org/r/256996/#review263996
Attachment #8992104 - Flags: review?(agaynor) → review+
Pushed by haftandilian@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/519aebccf07d
[Mac] Flash sandbox on Nightly/Beta causes OS X 10.9 file upload dialog Flash plugin crash r=Alex_Gaynor
https://hg.mozilla.org/mozilla-central/rev/519aebccf07d
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Please request Beta approval on this when you get a chance.
Flags: needinfo?(haftandilian)
I've requested uplift of bug 1474375 and listed this bug as a dependency.
Flags: needinfo?(haftandilian)
Comment on attachment 8992104 [details]
Bug 1475707 - [Mac] Flash sandbox on Nightly/Beta causes OS X 10.9 file upload dialog Flash plugin crash

Approval Request Comment
[Feature/Bug causing the regression]: required for bug 1474375 
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:
Attachment #8992104 - Flags: approval-mozilla-beta?
STR in comment 0. I'd like us to verify the fixes in nightly for Bug 1475722, Bug 1471977, and Bug 1475707 before we uplift for beta. (Hopefully for beta 13 next Monday)
Flags: qe-verify+
I managed to reproduce the issue using an older version of Nightly (2018-07-13) on Mac OS 10.9. As soon as the dialog box was displayed the Flash plugin crashed. 
I retested using the latest Nightly 63.0a1 and the bug is not reproducing anymore.
Flags: qe-verify+
Comment on attachment 8992104 [details]
Bug 1475707 - [Mac] Flash sandbox on Nightly/Beta causes OS X 10.9 file upload dialog Flash plugin crash

Fix was verified on Nightly63, Beta62+
Attachment #8992104 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Readding qe-verify+ to make sure beta 14 is also verified.
Flags: qe-verify+
I verified the fix on beta 62.0b14 using Mac OS 10.9 and the plugin is not crashing anymore.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.