1475884 - Setting an "inactive" Transceivers direction to "sendonly" after ReplaceTrack should send Audio to other peer

Status: RESOLVED DUPLICATE of bug 1472321

(Core :: WebRTC: Signaling, defect, P2)

Description

[Richard Brookes-Tee]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36

Steps to reproduce:

Open the example at https://jsfiddle.net/jib1/v7xrf6ut/
allow access to your microphone, 
and click the "Send Audio" button.


Actual results:

Since Firefox 61, Silence is sent.


Expected results:

The mic should be heard and the oscilloscope and spectrum should adapt to the input from your mic.

I did find that swapping the order of setting direction and replaceTrack(track) so that the set direction is first works.  So asked the question here https://github.com/w3c/webrtc-pc/issues/1933

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I can confirm this, as mentioned in https://github.com/w3c/webrtc-pc/issues/1933.

Transceiver-related, assigning to Byron for his attention.

Comment 2

[Nils Ohlmeier [:drno]]

Looks like a dupe of bug 1472321 to me.

Comment 3

[ben.browitt]

I'm getting the same error when adding a track to a recvonly peer connection:
var pc = new RTCPeerConnection(config);
var constraints = {offerToReceiveAudio: true, offerToReceiveVideo: true};
pc.createOffer(constraints).then(
 setLocalAndSendMessage.bind(this),
 handleError.bind(this)
);
pc.addTrack(localAudioTrack, localStream); // silent is sent

The above workaround works for me too:
var transceiver = pc.getTransceivers()[0];
transceiver.direction = 'sendrecv';
pc.addTrack(localAudioTrack, localStream);

Comment 4

[Byron Campen [:bwc]]

Can you check the latest nightly and see if this is fixed for you?

Comment 5

[Richard Brookes-Tee]

definitely, thanks, I'll check and let you know :)

Comment 6

[Richard Brookes-Tee]

Looking Good.  I've tried it both ways around (direction then replaceTrack and replaceTrack then direction) and starting/stopping several times so that the direction goes back to inactive then back to send and it's good.

Comment 7

[Byron Campen [:bwc]]

Sweet! Thanks for verifying!