[Static Analysis] DEAD_STORE errors in widget/xremoteclient/XRemoteClient.cpp

RESOLVED FIXED in Firefox 63

Status

()

P3
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: rbartlensky, Assigned: rbartlensky)

Tracking

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
widget/xremoteclient/XRemoteClient.cpp:475: error: DEAD_STORE
  The value written to &status (type int) is never used.
  473.       // protocol, we don't include it in our list.
  474.       if (aProgram && strcmp(aProgram, "any")) {
  475. >         status = XGetWindowProperty(mDisplay, w, mMozProgramAtom,
  476.                                       0, (65536 / sizeof(long)),
  477.                                       False, XA_STRING,

widget/xremoteclient/XRemoteClient.cpp:510: error: DEAD_STORE
  The value written to &status (type int) is never used.
  508.
  509.       if (username) {
  510. >         status = XGetWindowProperty(mDisplay, w, mMozUserAtom,
  511.                                       0, (65536 / sizeof(long)),
  512.                                       False, XA_STRING,

widget/xremoteclient/XRemoteClient.cpp:532: error: DEAD_STORE
  The value written to &status (type int) is never used.
  530.       // passed in.
  531.       if (aProfile) {
  532. >         status = XGetWindowProperty(mDisplay, w, mMozProfileAtom,
  533.                                       0, (65536 / sizeof(long)),
  534.                                       False, XA_STRING,


Shouldn't the `status` variable be used in the above cases?
(Assignee)

Updated

8 months ago
Blocks: 1175203
Comment hidden (mozreview-request)

Comment 2

8 months ago
mozreview-review
Comment on attachment 8992590 [details]
Bug 1475949: Fix DEAD_STORE issues in XRemoteClient.

https://reviewboard.mozilla.org/r/257458/#review265090
Attachment #8992590 - Flags: review?(jhorak) → review+
(Assignee)

Updated

8 months ago
Keywords: checkin-needed

Comment 3

8 months ago
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9c6b8e2e0ea
Fix DEAD_STORE issues in XRemoteClient. r=jhorak
Keywords: checkin-needed

Comment 4

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a9c6b8e2e0ea
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.