1475949 - [Static Analysis] DEAD_STORE errors in widget/xremoteclient/XRemoteClient.cpp

Status: RESOLVED FIXED

(Core :: Widget, enhancement, P3)

Description

[Robert Bartlensky [:rbartlensky]]

widget/xremoteclient/XRemoteClient.cpp:475: error: DEAD_STORE
  The value written to &status (type int) is never used.
  473.       // protocol, we don't include it in our list.
  474.       if (aProgram && strcmp(aProgram, "any")) {
  475. >         status = XGetWindowProperty(mDisplay, w, mMozProgramAtom,
  476.                                       0, (65536 / sizeof(long)),
  477.                                       False, XA_STRING,

widget/xremoteclient/XRemoteClient.cpp:510: error: DEAD_STORE
  The value written to &status (type int) is never used.
  508.
  509.       if (username) {
  510. >         status = XGetWindowProperty(mDisplay, w, mMozUserAtom,
  511.                                       0, (65536 / sizeof(long)),
  512.                                       False, XA_STRING,

widget/xremoteclient/XRemoteClient.cpp:532: error: DEAD_STORE
  The value written to &status (type int) is never used.
  530.       // passed in.
  531.       if (aProfile) {
  532. >         status = XGetWindowProperty(mDisplay, w, mMozProfileAtom,
  533.                                       0, (65536 / sizeof(long)),
  534.                                       False, XA_STRING,


Shouldn't the `status` variable be used in the above cases?

Comment 1

[Robert Bartlensky [:rbartlensky]]

Attachment: Bug 1475949: Fix DEAD_STORE issues in XRemoteClient.

Review commit: https://reviewboard.mozilla.org/r/257458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257458/

Comment 2

[Jan Horak [:jhorak]]

Comment on attachment 8992590 [details]
Bug 1475949: Fix DEAD_STORE issues in XRemoteClient.

https://reviewboard.mozilla.org/r/257458/#review265090

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9c6b8e2e0ea
Fix DEAD_STORE issues in XRemoteClient. r=jhorak

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a9c6b8e2e0ea