1476015 - [Static Analysis] DEAD_STORE error in uriloader/exthandler/unix/nsOSHelperAppService.cpp

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Robert Bartlensky [:rbartlensky]]

uriloader/exthandler/unix/nsOSHelperAppService.cpp:225: error: DEAD_STORE
  The value written to &rv (type int) is never used.
  223.     LOG(("-- LookUpTypeAndDescription for extension '%s'\n",
  224.          NS_LossyConvertUTF16toASCII(aFileExtension).get()));
  225. >   nsresult rv = NS_OK;
  226.     nsAutoString mimeFileName;
  227.

Comment 1

[Robert Bartlensky [:rbartlensky]]

uriloader/exthandler/unix/nsOSHelperAppService.cpp:318: error: DEAD_STORE
  The value written to &rv (type int) is never used.
  316.     LOG(("Using extension '%s'\n",
  317.          NS_LossyConvertUTF16toASCII(aFileExtension).get()));
  318. >   nsresult rv = NS_OK;
  319.     nsCOMPtr<nsIFileInputStream> mimeFile;
  320.     nsCOMPtr<nsILineInputStream> mimeTypes;

Comment 2

[Robert Bartlensky [:rbartlensky]]

uriloader/exthandler/unix/nsOSHelperAppService.cpp:441: error: DEAD_STORE
  The value written to &rv (type int) is never used.
  439.          NS_LossyConvertUTF16toASCII(aMajorType).get(),
  440.          NS_LossyConvertUTF16toASCII(aMinorType).get()));
  441. >   nsresult rv = NS_OK;
  442.     nsAutoString mimeFileName;
  443.

Comment 3

[Robert Bartlensky [:rbartlensky]]

Attachment: Bug 1476015: Fix DEAD_STORE issues reported by infer.

Review commit: https://reviewboard.mozilla.org/r/257238/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257238/

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8992384 [details]
Bug 1476015: Fix DEAD_STORE issues reported by infer.

https://reviewboard.mozilla.org/r/257238/#review264070

Thank you!

::: commit-message-2ed15:1
(Diff revision 1)
> +Bug 1476015: Fix DEAD_STORE issues.

Perhaps this should say "Fix DEAD_STORE issues reported by Coverity"?

Comment 5

[Robert Bartlensky [:rbartlensky]]

Sure, I will change it now.

Comment 6

[Robert Bartlensky [:rbartlensky]]

Comment on attachment 8992384 [details]
Bug 1476015: Fix DEAD_STORE issues reported by infer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257238/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99ac85a273af
Fix DEAD_STORE issues reported by infer. r=froydnj

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/99ac85a273af