[Static Analysis] DEAD_STORE error in uriloader/exthandler/unix/nsOSHelperAppService.cpp

RESOLVED FIXED in Firefox 63

Status

()

Product:
Core
Component:
Document Navigation
Importance:
P2
normal
Status:
RESOLVED FIXED
Reported:
8 months ago
Modified:
8 months ago

People

(Reporter: rbartlensky, Assigned: rbartlensky)

Tracking

Version:
unspecified
Target:
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Bug 1476015: Fix DEAD_STORE issues reported by infer.
59 bytes, text/x-review-board-request
froydnj
: review+
Details
(Assignee)

Description

•
8 months ago 
uriloader/exthandler/unix/nsOSHelperAppService.cpp:225: error: DEAD_STORE
  The value written to &rv (type int) is never used.
  223.     LOG(("-- LookUpTypeAndDescription for extension '%s'\n",
  224.          NS_LossyConvertUTF16toASCII(aFileExtension).get()));
  225. >   nsresult rv = NS_OK;
  226.     nsAutoString mimeFileName;
  227.
(Assignee)

Comment 1

•
8 months ago 
uriloader/exthandler/unix/nsOSHelperAppService.cpp:318: error: DEAD_STORE
  The value written to &rv (type int) is never used.
  316.     LOG(("Using extension '%s'\n",
  317.          NS_LossyConvertUTF16toASCII(aFileExtension).get()));
  318. >   nsresult rv = NS_OK;
  319.     nsCOMPtr<nsIFileInputStream> mimeFile;
  320.     nsCOMPtr<nsILineInputStream> mimeTypes;
(Assignee)

Comment 2

•
8 months ago 
uriloader/exthandler/unix/nsOSHelperAppService.cpp:441: error: DEAD_STORE
  The value written to &rv (type int) is never used.
  439.          NS_LossyConvertUTF16toASCII(aMajorType).get(),
  440.          NS_LossyConvertUTF16toASCII(aMinorType).get()));
  441. >   nsresult rv = NS_OK;
  442.     nsAutoString mimeFileName;
  443.
Comment hidden (mozreview-request)

Comment 4

•
8 months ago
mozreview-review 
Comment on attachment 8992384 [details]
Bug 1476015: Fix DEAD_STORE issues reported by infer.

https://reviewboard.mozilla.org/r/257238/#review264070

Thank you!

::: commit-message-2ed15:1
(Diff revision 1)
> +Bug 1476015: Fix DEAD_STORE issues.

Perhaps this should say "Fix DEAD_STORE issues reported by Coverity"?
Attachment #8992384 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 5

•
8 months ago 
Sure, I will change it now.
Comment hidden (mozreview-request)
(Assignee)

Updated

•
8 months ago
Keywords: checkin-needed

Comment 7

•
8 months ago 
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99ac85a273af
Fix DEAD_STORE issues reported by infer. r=froydnj
Keywords: checkin-needed
Priority: -- → P2

Comment 8

•
8 months ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/99ac85a273af
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.