Closed Bug 1476054 Opened 7 years ago Closed 7 years ago

Sync some servo changes.

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

No description provided.
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/a2bb0089cf1d Move `float` CSS property outside mako. r=emilio https://hg.mozilla.org/integration/mozilla-inbound/rev/ef2a43e3fc6c Fixes and cleanups for Servo PR #21139. r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/62293a989ed2 Move `clear` CSS property outside mako. r=emilio https://hg.mozilla.org/integration/mozilla-inbound/rev/0a712d7bcb66 Fixes and cleanups for Servo PR #21156. r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/cc571c618e4c Fix Servo build and unit tests build. r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/f4941fe345ad Remove a useless cfg. r=me
Backed out 6 changesets (bug 1476054) for failing on servo/ports/geckolib/glue.rs on a CLOSED TREE Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/6339739cba9a0099d6bbefa294ce22989935ab69 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=f4941fe345ade851ebd49fecea9f89aa3bfbc79f Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=188441035&repo=mozilla-inbound&lineNumber=4630 Log snippet: [task 2018-07-16T20:22:03.736Z] 20:22:03 INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/css-grid/grid-placement-implicit-named-areas-001.html | 11 / 280 (3%) [task 2018-07-16T20:22:03.744Z] 20:22:03 ERROR - thread '<unnamed>' panicked at 'stylo: Don't know how to handle presentation property', servo/ports/geckolib/glue.rs:3960:16 [task 2018-07-16T20:22:03.745Z] 20:22:03 INFO - stack backtrace: [task 2018-07-16T20:22:03.964Z] 20:22:03 INFO - 0: 0x7ff9551e46f2 - std::sys::unix::backtrace::tracing::imp::unwind_backtrace::h4adf28aee36be64a [task 2018-07-16T20:22:03.966Z] 20:22:03 INFO - 1: 0x7ff9551d680c - std::panicking::default_hook::{{closure}}::h3feea165746fea16 [task 2018-07-16T20:22:03.967Z] 20:22:03 INFO - 2: 0x7ff9551d5c69 - std::panicking::default_hook::hf6fdb8e9192be332 [task 2018-07-16T20:22:03.968Z] 20:22:03 INFO - 3: 0x7ff9551d581e - std::panicking::rust_panic_with_hook::h608586f043d70222 [task 2018-07-16T20:22:03.970Z] 20:22:03 INFO - 4: 0x7ff954e72016 - std::panicking::begin_panic::h18095f6c1bd59f4f [task 2018-07-16T20:22:03.971Z] 20:22:03 INFO - 5: 0x7ff954f323e8 - Servo_DeclarationBlock_SetKeywordValue [task 2018-07-16T20:22:03.972Z] 20:22:03 INFO - 6: 0x7ff952c0049f - _ZN7mozilla3dom13HTMLBRElement21MapAttributesIntoRuleEPK18nsMappedAttributesRNS_18MappedDeclarationsE [task 2018-07-16T20:22:03.973Z] 20:22:03 INFO - 7: 0x7ff9521e2afb - _ZN18nsMappedAttributes29LazilyResolveServoDeclarationEP11nsIDocument [task 2018-07-16T20:22:03.974Z] 20:22:03 INFO - 8: 0x7ff9534d51e9 - _ZN16nsHTMLStyleSheet32CalculateMappedServoDeclarationsEv [task 2018-07-16T20:22:03.975Z] 20:22:03 INFO - 9: 0x7ff9534bf06f - _ZN7mozilla13ServoStyleSet34ResolveMappedAttrDeclarationBlocksEv [task 2018-07-16T20:22:03.976Z] 20:22:03 INFO - 10: 0x7ff9534bf0b0 - _ZN7mozilla13ServoStyleSet15PreTraverseSyncEv [task 2018-07-16T20:22:03.977Z] 20:22:03 INFO - 11: 0x7ff9534bf158 - _ZN7mozilla13ServoStyleSet11PreTraverseENS_19ServoTraversalFlagsEPNS_3dom7ElementE [task 2018-07-16T20:22:03.978Z] 20:22:03 INFO - 12: 0x7ff9534c8ecd - _ZN7mozilla13ServoStyleSet13StyleDocumentENS_19ServoTraversalFlagsE [task 2018-07-16T20:22:03.979Z] 20:22:03 INFO - 13: 0x7ff953533274 - _ZN7mozilla14RestyleManager24DoProcessPendingRestylesENS_19ServoTraversalFlagsE [task 2018-07-16T20:22:03.980Z] 20:22:03 INFO - 14: 0x7ff95353a408 - _ZN7mozilla9PresShell27DoFlushPendingNotificationsENS_14ChangesToFlushE [task 2018-07-16T20:22:03.981Z] 20:22:03 INFO - 15: 0x7ff95218e35b - _ZN11nsIDocument25FlushPendingNotificationsEN7mozilla14ChangesToFlushE [task 2018-07-16T20:22:03.982Z] 20:22:03 INFO - 16: 0x7ff95218e3e8 - _ZN11nsIDocument25FlushPendingNotificationsEN7mozilla9FlushTypeE [task 2018-07-16T20:22:03.983Z] 20:22:03 INFO - 17: 0x7ff951c26eb8 - _ZN11nsDocLoader16DocLoaderIsEmptyEb.part.73 [task 2018-07-16T20:22:03.984Z] 20:22:03 INFO - 18: 0x7ff951c277f5 - _ZN11nsDocLoader13OnStopRequestEP10nsIRequestP11nsISupports8nsresult [task 2018-07-16T20:22:03.984Z] 20:22:03 INFO - 19: 0x7ff9513bbce3 - _ZN7mozilla3net11nsLoadGroup13RemoveRequestEP10nsIRequestP11nsISupports8nsresult [task 2018-07-16T20:22:03.985Z] 20:22:03 INFO - 20: 0x7ff95218edbe - _ZN11nsIDocument15DoUnblockOnloadEv [task 2018-07-16T20:22:03.986Z] 20:22:03 INFO - 21: 0x7ff95218eec1 - _ZN10nsDocument13UnblockOnloadEb [task 2018-07-16T20:22:03.988Z] 20:22:03 INFO - 22: 0x7ff9521bf4ab - _ZN11nsIDocument27DispatchContentLoadedEventsEv [task 2018-07-16T20:22:03.989Z] 20:22:03 INFO - 23: 0x7ff952177386 - _ZN7mozilla6detail18RunnableMethodImplIP11nsIDocumentMS2_FvvELb1ELNS_12RunnableKindE0EJEE3RunEv [task 2018-07-16T20:22:03.990Z] 20:22:03 INFO - 24: 0x7ff95131fbec - _ZN7mozilla14SchedulerGroup8Runnable3RunEv [task 2018-07-16T20:22:03.991Z] 20:22:03 INFO - 25: 0x7ff9513352a9 - _ZN8nsThread16ProcessNextEventEbPb.part.250 [task 2018-07-16T20:22:03.993Z] 20:22:03 INFO - 26: 0x7ff95132ce6a - _Z19NS_ProcessNextEventP9nsIThreadb [task 2018-07-16T20:22:03.994Z] 20:22:03 INFO - 27: 0x7ff95178bb21 - _ZN7mozilla3ipc11MessagePump3RunEPN4base11MessagePump8DelegateE [task 2018-07-16T20:22:04.000Z] 20:22:04 INFO - 28: 0x7ff951760a01 - _ZN11MessageLoop3RunEv [task 2018-07-16T20:22:04.001Z] 20:22:04 INFO - 29: 0x7ff95338a6b8 - _ZN14nsBaseAppShell3RunEv [task 2018-07-16T20:22:04.004Z] 20:22:04 INFO - 30: 0x7ff95445719b - _Z15XRE_RunAppShellv [task 2018-07-16T20:22:04.005Z] 20:22:04 INFO - 31: 0x7ff951760a01 - _ZN11MessageLoop3RunEv [task 2018-07-16T20:22:04.006Z] 20:22:04 INFO - 32: 0x7ff9544574c1 - _Z20XRE_InitChildProcessiPPcPK12XREChildData [task 2018-07-16T20:22:04.007Z] 20:22:04 INFO - 33: 0x406326 - _Z20content_process_mainPN7mozilla9BootstrapEiPPc.part.2 [task 2018-07-16T20:22:04.010Z] 20:22:04 INFO - 34: 0x405e8f - main [task 2018-07-16T20:22:04.011Z] 20:22:04 INFO - 35: 0x7ff96226082f - __libc_start_main [task 2018-07-16T20:22:04.011Z] 20:22:04 INFO - 36: 0x406104 - <unknown> [task 2018-07-16T20:22:04.016Z] 20:22:04 INFO - Redirecting call to abort() to mozalloc_abort [task 2018-07-16T20:22:04.085Z] 20:22:04 INFO - [Parent 4510, Gecko_IOThread] WARNING: pipe error (87): Connection reset by peer: file /builds/worker/workspace/build/src/ipc/chromium/src/chrome/common/ipc_channel_posix.cc, line 353 [task 2018-07-16T20:22:04.085Z] 20:22:04 INFO - ###!!! [Parent][MessageChannel] Error: (msgtype=0x170080,name=PBrowser::Msg_Destroy) Channel error: cannot send/recv [task 2018-07-16T20:22:04.102Z] 20:22:04 INFO - A content process crashed and MOZ_CRASHREPORTER_SHUTDOWN is set, shutting down [task 2018-07-16T20:22:04.252Z] 20:22:04 INFO - !!! error running onStopped callback: TypeError: callback is not a function [task 2018-07-16T20:22:04.272Z] 20:22:04 INFO - JavaScript error: chrome://reftest/content/reftest.jsm, line 1547: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIPropertyBag2.getPropertyAsAString] [task 2018-07-16T20:22:04.389Z] 20:22:04 INFO - 1531772524380 Marionette DEBUG Received observer notification xpcom-will-shutdown [task 2018-07-16T20:22:04.391Z] 20:22:04 INFO - 1531772524380 Marionette INFO Stopped listening on port 2828 [task 2018-07-16T20:22:04.395Z] 20:22:04 INFO - 1531772524380 Marionette DEBUG Remote service is inactive [task 2018-07-16T20:22:04.476Z] 20:22:04 INFO - REFTEST INFO | Downloading symbols from: https://queue.taskcluster.net/v1/task/R8HTizEmQd-I4a5FQCuxdg/artifacts/public/build/target.crashreporter-symbols.zip [task 2018-07-16T20:22:10.330Z] 20:22:10 INFO - REFTEST INFO | Copy/paste: /usr/local/bin/linux64-minidump_stackwalk /tmp/tmpj1mEKf.mozrunner/minidumps/655913aa-38db-b961-d6d1-de28f421de12.dmp /tmp/tmpaCj_lI [task 2018-07-16T20:22:18.191Z] 20:22:18 INFO - REFTEST INFO | Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/655913aa-38db-b961-d6d1-de28f421de12.dmp [task 2018-07-16T20:22:18.192Z] 20:22:18 INFO - REFTEST INFO | Saved app info as /builds/worker/workspace/build/blobber_upload_dir/655913aa-38db-b961-d6d1-de28f421de12.extra [task 2018-07-16T20:22:18.259Z] 20:22:18 INFO - REFTEST PROCESS-CRASH | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/css-grid/grid-placement-implicit-named-areas-001.html | application crashed [@ mozalloc_abort] [task 2018-07-16T20:22:18.260Z] 20:22:18 INFO - Crash dump filename: /tmp/tmpj1mEKf.mozrunner/minidumps/655913aa-38db-b961-d6d1-de28f421de12.dmp [task 2018-07-16T20:22:18.260Z] 20:22:18 INFO - Operating system: Linux [task 2018-07-16T20:22:18.261Z] 20:22:18 INFO - 0.0.0 Linux 4.4.0-1014-aws #14taskcluster1-Ubuntu SMP Tue Apr 3 10:27:00 UTC 2018 x86_64 [task 2018-07-16T20:22:18.261Z] 20:22:18 INFO - CPU: amd64 [task 2018-07-16T20:22:18.262Z] 20:22:18 INFO - family 6 model 62 stepping 4 [task 2018-07-16T20:22:18.262Z] 20:22:18 INFO - 2 CPUs [task 2018-07-16T20:22:18.263Z] 20:22:18 INFO - [task 2018-07-16T20:22:18.263Z] 20:22:18 INFO - GPU: UNKNOWN [task 2018-07-16T20:22:18.264Z] 20:22:18 INFO - [task 2018-07-16T20:22:18.264Z] 20:22:18 INFO - Crash reason: SIGSEGV [task 2018-07-16T20:22:18.265Z] 20:22:18 INFO - Crash address: 0x0 [task 2018-07-16T20:22:18.265Z] 20:22:18 INFO - Process uptime: not available [task 2018-07-16T20:22:18.266Z] 20:22:18 INFO - [task 2018-07-16T20:22:18.266Z] 20:22:18 INFO - Thread 0 (crashed) [task 2018-07-16T20:22:18.267Z] 20:22:18 INFO - 0 firefox!mozalloc_abort [mozalloc_abort.cpp:f4941fe345ade851ebd49fecea9f89aa3bfbc79f : 34 + 0x0] [task 2018-07-16T20:22:18.267Z] 20:22:18 INFO - rax = 0x0000000000635c80 rdx = 0x000000000042cdc6 [task 2018-07-16T20:22:18.268Z] 20:22:18 INFO - rcx = 0x00007ff9623372dd rbx = 0x00007ff962605700 [task 2018-07-16T20:22:18.268Z] 20:22:18 INFO - rsi = 0x00007ff962606770 rdi = 0x0000000000000000 [task 2018-07-16T20:22:18.269Z] 20:22:18 INFO - rbp = 0x00007ffd82898580 rsp = 0x00007ffd82898570 [task 2018-07-16T20:22:18.269Z] 20:22:18 INFO - r8 = 0x00007ff962606770 r9 = 0x00007ff9638f0740 [task 2018-07-16T20:22:18.270Z] 20:22:18 INFO - r10 = 0x0000000000000422 r11 = 0x0000000000000000 [task 2018-07-16T20:22:18.270Z] 20:22:18 INFO - r12 = 0x00007ff961929810 r13 = 0x000000000000001c [task 2018-07-16T20:22:18.271Z] 20:22:18 INFO - r14 = 0x0000000000000f78 r15 = 0x0000000000000010 [task 2018-07-16T20:22:18.271Z] 20:22:18 INFO - rip = 0x00000000004118f6 [task 2018-07-16T20:22:18.272Z] 20:22:18 INFO - Found by: given as instruction pointer in context [task 2018-07-16T20:22:18.272Z] 20:22:18 INFO - 1 firefox!abort [mozalloc_abort.cpp:f4941fe345ade851ebd49fecea9f89aa3bfbc79f : 81 + 0x5] [task 2018-07-16T20:22:18.273Z] 20:22:18 INFO - rbx = 0x0000000000000001 rbp = 0x00007ffd82898590 [task 2018-07-16T20:22:18.273Z] 20:22:18 INFO - rsp = 0x00007ffd82898590 r12 = 0x00007ff961929810 [task 2018-07-16T20:22:18.274Z] 20:22:18 INFO - r13 = 0x000000000000001c r14 = 0x0000000000000f78 [task 2018-07-16T20:22:18.274Z] 20:22:18 INFO - r15 = 0x0000000000000010 rip = 0x00000000004118c0 [task 2018-07-16T20:22:18.275Z] 20:22:18 INFO - Found by: call frame info [task 2018-07-16T20:22:18.275Z] 20:22:18 INFO - 2 libxul.so!panic_abort::__rust_start_panic::abort [lib.rs:915ac660268eeff1cee8f6e59670f19b501a143e : 61 + 0x6] [task 2018-07-16T20:22:18.276Z] 20:22:18 INFO - rbx = 0x0000000000000001 rbp = 0x00007ff95740ba08 [task 2018-07-16T20:22:18.276Z] 20:22:18 INFO - rsp = 0x00007ffd828985a0 r12 = 0x00007ff961929810 [task 2018-07-16T20:22:18.277Z] 20:22:18 INFO - r13 = 0x000000000000001c r14 = 0x0000000000000f78 [task 2018-07-16T20:22:18.277Z] 20:22:18 INFO - r15 = 0x0000000000000010 rip = 0x00007ff9551e74e6 [task 2018-07-16T20:22:18.278Z] 20:22:18 INFO - Found by: call frame info [task 2018-07-16T20:22:18.278Z] 20:22:18 INFO - 3 libxul.so!__rust_start_panic [lib.rs:915ac660268eeff1cee8f6e59670f19b501a143e : 56 + 0x6] [task 2018-07-16T20:22:18.279Z] 20:22:18 INFO - rbx = 0x0000000000000001 rbp = 0x00007ff95740ba08 [task 2018-07-16T20:22:18.279Z] 20:22:18 INFO - rsp = 0x00007ffd828985b0 r12 = 0x00007ff961929810 [task 2018-07-16T20:22:18.280Z] 20:22:18 INFO - r13 = 0x000000000000001c r14 = 0x0000000000000f78 [task 2018-07-16T20:22:18.280Z] 20:22:18 INFO - r15 = 0x0000000000000010 rip = 0x00007ff9551e74d6 [task 2018-07-16T20:22:18.281Z] 20:22:18 INFO - Found by: call frame info [task 2018-07-16T20:22:18.281Z] 20:22:18 INFO - 4 libxul.so!std::panicking::rust_panic_with_hook [panicking.rs:915ac660268eeff1cee8f6e59670f19b501a143e : 559 + 0x5] [task 2018-07-16T20:22:18.282Z] 20:22:18 INFO - rbx = 0x0000000000000001 rbp = 0x00007ff95740ba08 [task 2018-07-16T20:22:18.282Z] 20:22:18 INFO - rsp = 0x00007ffd828985c0 r12 = 0x00007ff961929810 [task 2018-07-16T20:22:18.283Z] 20:22:18 INFO - r13 = 0x000000000000001c r14 = 0x0000000000000f78 [task 2018-07-16T20:22:18.283Z] 20:22:18 INFO - r15 = 0x0000000000000010 rip = 0x00007ff9551d584e [task 2018-07-16T20:22:18.284Z] 20:22:18 INFO - Found by: call frame info [task 2018-07-16T20:22:18.284Z] 20:22:18 INFO - 5 libxul.so!std::panicking::begin_panic [panicking.rs:915ac660268eeff1cee8f6e59670f19b501a143e : 445 + 0x20] [task 2018-07-16T20:22:18.285Z] 20:22:18 INFO - rbx = 0x0000000000000003 rbp = 0x00007ffd82898710 [task 2018-07-16T20:22:18.285Z] 20:22:18 INFO - rsp = 0x00007ffd82898640 r12 = 0x00007ff94159d5c0 [task 2018-07-16T20:22:18.286Z] 20:22:18 INFO - r13 = 0x0000000000000000 r14 = 0x00007ff94a2a6d08 [task 2018-07-16T20:22:18.287Z] 20:22:18 INFO - r15 = 0x00007ffd82898a90 rip = 0x00007ff954e72017 [task 2018-07-16T20:22:18.287Z] 20:22:18 INFO - Found by: call frame info
Flags: needinfo?(emilio)
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/0486cd62a807 Move `float` CSS property outside mako. r=emilio https://hg.mozilla.org/integration/mozilla-inbound/rev/449941e7a840 Fixes and cleanups for Servo PR #21139. r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/fb59c8181fc9 Move `clear` CSS property outside mako. r=emilio https://hg.mozilla.org/integration/mozilla-inbound/rev/eb66264387a0 Fixes and cleanups for Servo PR #21156. r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/cf7d50bca264 Fix Servo build and unit tests build. r=me https://hg.mozilla.org/integration/mozilla-inbound/rev/e60abc5045e3 Remove a useless cfg. r=me
Blerg, I failed to see that clear was still used as a presentation property.
Flags: needinfo?(emilio)
Thanks Raul!
You need to log in before you can comment on or make changes to this bug.