1476084 - Set minwidth / minheight / maxwidth / maxheight on the payment dialog to prevent resizing

Status: RESOLVED WONTFIX

(Firefox :: WebPayments UI, enhancement)

Description

[Jared Wein [:jaws] (please needinfo? me)]

To prevent the payments dialog from being resizable on Linux, we can set the min- and max-{width/height} to the size of the dialog after opening.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1476084 - Set min and max widths and heights for the payment dialog to prevent the dialog from being resizable.

Review commit: https://reviewboard.mozilla.org/r/257316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257316/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8992450 [details]
Bug 1476084 - Set min and max widths and heights for the payment dialog to prevent the dialog from being resizable.

https://reviewboard.mozilla.org/r/257316/#review264226

::: browser/components/payments/content/paymentDialogWrapper.js:467
(Diff revision 1)
> +    let docElement = document.documentElement;
> +    let windowRect = docElement.getBoundingClientRect();
> +    docElement.setAttribute("minwidth", windowRect.width);
> +    docElement.setAttribute("maxwidth", windowRect.width);
> +    docElement.setAttribute("minheight", windowRect.height);
> +    docElement.setAttribute("maxheight", windowRect.height);

Is this working around resizable=no working on Linux? Why not get that fixed instead? This seems kinda hacky.

https://dxr.mozilla.org/mozilla-central/rev/085cdfb90903d4985f0de1dc7786522d9fb45596/browser/components/payments/paymentUIService.js#51

Comment 3

[Sam Foster [:sfoster] (he/him)]

Can we fix the form layout before we land this? Resizing the dialog is the only way to make the address and cc forms usable currently on Linux.

Comment 4

[Matthew N. [:MattN]]

(In reply to Sam Foster [:sfoster] from comment #3)
> Can we fix the form layout before we land this? Resizing the dialog is the
> only way to make the address and cc forms usable currently on Linux.

Even after I made the pages scrollable?

Comment 5

[Sam Foster [:sfoster] (he/him)]

Attachment: pr-shipping-screenshot.png

The credit card form is actually ok. But the address form is pretty awkward currently.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Yeah, we can wait to make the form layout more usable before we fix the resizing. This work is done right now to investigate how much work it would be if we continue down this path.

With the patch applied, the scrollbars still work, though they aren't so easy to find if you don't know they are there.

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 8992450 [details]
Bug 1476084 - Set min and max widths and heights for the payment dialog to prevent the dialog from being resizable.

https://reviewboard.mozilla.org/r/257316/#review264470

See comment 2 and bug 497401.

Comment 8

[Matthew N. [:MattN]]

After comparing the breakdown of window modal vs. tab modal, the current plan is to use a Tab Modal dialog since the level of effort is similar and tab modal is a much better UX.