1476158 - Enable dom.animations-api.core.enabled by default

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement)

Description

[Brian Birtles (:birtles)]

In bug 1471814 I have guarded all the stuff we are not ready to ship with separate prefs so we should now be able to turn on dom.animations-api.core.enabled in beta/release.

Specifically, enabling this gives us:

* Animation.ready/finished Promises (which should let us drop the polyfill
  introduced in bug 1449532)
* Animation.effect and the AnimationEffect/KeyframeEffect interfaces
  (i.e. ability to update keyframes / timing / target for animations in motion)

Comment 1

[Brian Birtles (:birtles)]

Intent to ship: https://groups.google.com/forum/#!topic/mozilla.dev.platform/fcFctnUjs7A

Comment 2

[Brian Birtles (:birtles)]

Attachment: Bug 1476158 - Guard CSSAnimation and CSSTransition interfaces behind getAnimations() pref;

The CSSAnimation and CSSTransition interfaces are only needed to represent CSS
animations and CSS transitions returned by the
{Document,Element}.getAnimations() API.

Bug 1471814 introduced the dom.animations-api.getAnimations.enabled pref but
neglected to guard the CSSAnimation and CSSTransition interfaces behind this
pref, leaving them guarded by the dom.animations-api.core.enabled pref instead.

This patch updates the pref used to guard these interfaces so that when we turn
on the dom.animations-api.core.enabled pref by default we don't also end up
shipping these interfaces.

Review commit: https://reviewboard.mozilla.org/r/257658/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257658/

Comment 3

[Brian Birtles (:birtles)]

Attachment: Bug 1476158 - Enable dom.animations-api.core.enabled on beta/release;

Intent to ship: https://groups.google.com/forum/#!topic/mozilla.dev.platform/fcFctnUjs7A

Review commit: https://reviewboard.mozilla.org/r/257660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257660/

Comment 4

[Brian Birtles (:birtles)]

Putting this up for review now although I should allow another day at least for responses to the intent to ship before landing.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8992820 [details]
Bug 1476158 - Guard CSSAnimation and CSSTransition interfaces behind getAnimations() pref;

https://reviewboard.mozilla.org/r/257658/#review264826

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8992821 [details]
Bug 1476158 - Enable dom.animations-api.core.enabled on beta/release;

https://reviewboard.mozilla.org/r/257660/#review264828

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32f324bf03c0
Guard CSSAnimation and CSSTransition interfaces behind getAnimations() pref; r=bz
https://hg.mozilla.org/integration/autoland/rev/0b41f0b2c5b7
Enable dom.animations-api.core.enabled on beta/release; r=bz

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/32f324bf03c0
https://hg.mozilla.org/mozilla-central/rev/0b41f0b2c5b7

Comment 9

[Eric Shepherd [:sheppy]]

I've submitted a PR against the browser compat database for this: https://github.com/mdn/browser-compat-data/pull/2650

I've also noted this change on Firefox 63 for developers.