1476211 - Call FlushSceneBuilds() in WebRenderBridgeParent::CompositeToTarget() during taking snapshot

Status: RESOLVED INVALID

(Core :: Graphics: WebRender, defect, P2)

Description

[Sotaro Ikeda [:sotaro]]

During taking snapshot, FlushSceneBuilds() is called before WebRenderBridgeParent::CompositeToTarget(). But it is not good. In the CompositeToTarget(), transaction of AsyncImagePipelineManager::ApplyAsyncImages() is sent asynchronously. But it is not applied to the snapshot. It is not good.

The problem was noticed by Bug 1475187 comment 5.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Call FlushSceneBuilds() in WebRenderBridgeParent::CompositeToTarget() during taking snapshot

Comment 2

[Sotaro Ikeda [:sotaro]]

Hmm, attachment 8992558 [details] [diff] [review] caused test failures :(

https://treeherder.mozilla.org/#/jobs?repo=try&revision=37813fad845ac4912fcf91bf5457c91334e2adc6

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8992558 [details] [diff] [review]
patch - Call FlushSceneBuilds() in WebRenderBridgeParent::CompositeToTarget() during taking snapshot

Review of attachment 8992558 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not really a fan of passing the flushSceneBuilds flag to FlushFrameGeneration. I like it better if they stay independent. Although I'm not convinced we need this at all (see my comment on the other bug)

Comment 4

[Sotaro Ikeda [:sotaro]]

Ok, I am going to do another way.