1476212 - Notify SPI_SETCLIENTAREAANIMATION changes to all descendant documents

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I've started setting Windows environment.  (Not finished yet, I've been seeing 'Getting Windows ready Don't turn off your computer' message for an hour..)

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Now I think I understand why calling NotifyThemeChanged() in the try in bug 1365045 comment 34 doesn't propagate the change into subframes.  The reason is we use in MediaFeatureValuesChanged instead of MediaFeatureValuesChangedAllDocuments nsPresContext::RefreshSystemMetrics().  I wonder there is no system metrics affecting in subframes?

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1476212 - Notify the system setting change corresponding to prefers-reduced-motion.

Even with this patch, the setting change doesn't affect media queries in sub
frames due to bug 1478212.  But the bug is a pre-existing issue, for example
system color settings don't affect contents in sub frames either.  So we can
land this patch as it is.

Note that there is no way to write an automation test for this unfortunately.

Review commit: https://reviewboard.mozilla.org/r/259268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259268/

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8994743 [details]
Bug 1476212 - Notify the system setting change corresponding to prefers-reduced-motion.

https://reviewboard.mozilla.org/r/259268/#review266778

::: widget/windows/nsWindow.cpp:5320
(Diff revision 1)
>      {
>        if (wParam == SPI_SETKEYBOARDDELAY) {
>          // CaretBlinkTime is cached in nsLookAndFeel
>          NotifyThemeChanged();
>          break;
> +      } else if (wParam == SPI_SETCLIENTAREAANIMATION) {

Lets move this up with the SPI_SETKEYBOARDDELAY check, don't see why we need the extra else if block.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8994743 [details]
Bug 1476212 - Notify the system setting change corresponding to prefers-reduced-motion.

https://reviewboard.mozilla.org/r/259268/#review266812

::: widget/windows/nsWindow.cpp:5320
(Diff revision 1)
>      {
>        if (wParam == SPI_SETKEYBOARDDELAY) {
>          // CaretBlinkTime is cached in nsLookAndFeel
>          NotifyThemeChanged();
>          break;
> +      } else if (wParam == SPI_SETCLIENTAREAANIMATION) {

Oh right, indeed.  Thanks for the review!

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8994743 [details]
Bug 1476212 - Notify the system setting change corresponding to prefers-reduced-motion.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/259268/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c108e6f927d1
Notify the system setting change corresponding to prefers-reduced-motion. r=jimm

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/c108e6f927d1