1476221 - The autocomplete form pop-up doesn't appear directly next to the related input field on some pages

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[miralobontiu]

Attachment: screenshot

Device(s):
 - LG G5 (Android 7.0);
 - Samsung Galaxy S6 (Android 7.0);
 - Huawei P9 Lite (Android 6.0);

Build(s):
 - Nightly 63.0a1 (2018-07-16);
 - Beta 62.0b7;
 - Release 61.0;

Steps to reproduce:
 1. Navigate to https://www-archive.mozilla.org/quality/browser/front-end/testcases/wallet/login.html.
 2. Fill in "Username" and "Password" fields and tap "Log in".
 3. Choose "Remember" from the doorhanger pop-up.
 4. Open the page from step 1 in another tab.
 5. Tap on "Username" field.
 6. Observe the autocomplete form pop-up`s location.

Expected result:
 The autocomplete form pop-up should be displayed under the "Username" field.
 
Actual result:
 The autocomplete form pop-up is not displayed under the "Username" field.

Note:
 This is not reproducible on Chrome.

Comment 1

[Jan Henning [:JanH]]

This doesn't happen on all pages, but on the page mentioned above I'm seeing this as well.

Comment 2

[miralobontiu]

Ran a regression using Huawei P9 Lite (Android 6.0).

Regressionwindow:
First known bad build: 2018-07-11 21:43:58
Last known good build: 2018-07-11 21:47:51

Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3aca103e49150145dbff910be15e7886b7c4495a&tochange=fe17acc6e291e54463db3ea82697c714ae5a4b27

Comment 3

[Sylvestre Ledru [:Sylvestre]]

afaik, the tracking keyword "fennec" isn't used anymore.

Comment 4

[Stefan Deiac]

It's reproducible also on https://bugzilla.mozilla.org. Device tested: Oneplus Two (Android 6.0.1)

Comment 5

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 6

[:sdaswani]

Andreas should we work on this?

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Susheel, will your team work on this 63 regression?

Comment 8

[:sdaswani]

Pascal I'm still waiting for Andreas' on this but as it's a regression I'll put it on our high priority queue.

Vlad this may need to get fixed sooner rather than later given it's a regression in 63.

Comment 9

[Vlad Baicu]

I've tried debugging this quite a bit with WebIDE but it seems to be a Gecko issue. Unfortunately I don't think we can be of much help on this one

Comment 10

[:sdaswani]

Looks like a gecko issue David B.

Comment 11

[David Bolter [:davidb] (NeedInfo me for attention)]

I'm not sure what the most likely suspect is in the regression range (comment 2). Botond do you think this could be fallout from bug 1423011?

Comment 12

[Botond Ballo [:botond]]

Yes, this does look like a regression from bug 1423011. I will investigate.

Comment 13

[Botond Ballo [:botond]]

The issue here is basically analogous to the issue described in bug 1484597 comment 2, it just applies to a different popup (the form auto-fill popup rather than floating toolbar).

Comment 14

[Botond Ballo [:botond]]

Attachment: Bug 1476221 - Expose the offset of the visual viewport relative to the layout viewport to chrome JS code via nsIDOMWindowUtils. r?mstange

Comment 15

[Botond Ballo [:botond]]

Attachment: Bug 1476221 - Keep the bounding client rect of the 'FormAssist:AutoCompleteResults' message relative to the visual viewport. r?mstange

Depends on D6090

Comment 16

[Andreas Bovens [:abovens]]

> Pascal I'm still waiting for Andreas' on this

Apologies for the delay. Yes, let's work on this - great this is being tackled. It will probably be relevant for Lockbox-powered autocompletion as well.

Comment 17

[Markus Stange [:mstange]]

Comment on attachment 9009782 [details]
Bug 1476221 - Expose the offset of the visual viewport relative to the layout viewport to chrome JS code via nsIDOMWindowUtils. r?mstange

Markus Stange [:mstange] has approved the revision.

Comment 18

[Markus Stange [:mstange]]

Comment on attachment 9009783 [details]
Bug 1476221 - Keep the bounding client rect of the 'FormAssist:AutoCompleteResults' message relative to the visual viewport. r?mstange

Markus Stange [:mstange] has approved the revision.

Comment 19

[David Durst [:ddurst]]

Are these good to land, then?

Comment 20

[Botond Ballo [:botond]]

Yup. There is a code dependency on bug 1484597 which I failed to annotate, so I was just waiting for that to land.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b91faf6f965b
Expose the offset of the visual viewport relative to the layout viewport to chrome JS code via nsIDOMWindowUtils. r=mstange
https://hg.mozilla.org/integration/autoland/rev/3387f039baf9
Keep the bounding client rect of the 'FormAssist:AutoCompleteResults' message relative to the visual viewport. r=mstange

Comment 22

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b91faf6f965b
https://hg.mozilla.org/mozilla-central/rev/3387f039baf9

Comment 23

[Pascal Chevrel:pascalc (PTO until April 26)]

Botond, could you request an uplift to beta please? thanks

Comment 24

[Botond Ballo [:botond]]

Comment on attachment 9009782 [details]
Bug 1476221 - Expose the offset of the visual viewport relative to the layout viewport to chrome JS code via nsIDOMWindowUtils. r?mstange

Note: this approval request applies to both patches together.

Approval Request Comment
[Feature/Bug causing the regression]:
  Bug 1423011

[User impact if declined]:
  When zoomed in, tapping on a form field may result in the
  auto-complete popup being positioned incorrectly (including
  potentially completely offscreen, so it's not visible at all)

[Is this code covered by automated tests?]:
  Not that I'm aware of.

[Has the fix been verified in Nightly?]:
  Yes, by me.

[Needs manual test from QE? If yes, steps to reproduce]: 
  No.

[List of other uplifts needed for the feature/fix]:
  Bug 1484597.

[Is the change risky?]:
  Low to moderate risk.
 
[Why is the change risky/not risky?]:
  It's a simple and targeted fix, but as far as I'm aware the 
  code in question doesn't have good test coverage.

[String changes made/needed]:
  No.

Comment 25

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9009782 [details]
Bug 1476221 - Expose the offset of the visual viewport relative to the layout viewport to chrome JS code via nsIDOMWindowUtils. r?mstange

Fix for a tracked 63 regression, uplift approved for 63 beta 11, thanks.

Comment 26

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2658fb7e9e99
https://hg.mozilla.org/releases/mozilla-beta/rev/52c77c08b8a5

Comment 27

[Sorina Florean [:sflorean]]

Verified as fixed on the latest build, 63.0b11.
Devices: Motorola Nexus 6(Android 7.1.1) and Xiaomi Mi Pad 2(Android 5.1).

Comment 28

[Stefan Deiac]

Verified as fixed on the latest version of Nightly 64.0a1 (2018-10-08).
Devices: Sony Xperia Z5 Premium	(Android 6.0.1) and OnePlus 5T (Android 8.1.0).