1476285 - The close button for snippets is showing up in the middle of the snippets on Nightly

Status: RESOLVED FIXED

(Snippets Graveyard :: General, defect)

Description

[(no longer active)]

Attachment: Screenshot

Please see the screenshot for how the close button is positioned right now.

Comment 1

[Tracy Walker [:tracy]]

Noticed this recently as well.

STR:

1) Open a new tab (about:newtab)
2) Hover the snippet at the bottom of the page

expected result:
The close button [X] should be located at the right side of the banner

tested result: 
as Ehsan posted, the [X] button is in the center of the snippet banner.

Comment 2

[Giorgos Logiotatidis [:giorgos]]

Thanks for reporting.

Kate, Andrei did something change in AS in nightly that would have caused this behavior? We're serving the same template on all Release, Beta and Nightly but only Nightly gets the misplaced close button.

Comment 3

[Andrei Oprea [:andreio]]

Tracked down the issue to the renaming of the offset-* properties to inset-* in bug 1464782. There was a backport to Activity Stream but snippet code is external to our repository.
A pull request was made to update the snippets css [0] and use both declarations (in order to support both release and nightly channels).

[0] https://github.com/mozmeao/snippets-service/pull/610

Comment 4

[Kate Hudson :k88hudson]

Should we close this since this requires no changes in Firefox / affects code outside of Firefox only? What's the right tracking flag to set for that?

Comment 5

[Kate Hudson :k88hudson]

There might be some stuff to fix up here too: https://github.com/mozmeao/snippets

Comment 6

[Giorgos Logiotatidis [:giorgos]]

(In reply to Kate Hudson :k88hudson from comment #4)
> Should we close this since this requires no changes in Firefox / affects
> code outside of Firefox only? What's the right tracking flag to set for that?

This is under the snippets component, so lets keep it. Feel free to remove the tracking flags, I don't use those

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

(In reply to Kate Hudson :k88hudson from comment #4)
> Should we close this since this requires no changes in Firefox / affects
> code outside of Firefox only? What's the right tracking flag to set for that?

We are tracking that for Firefox 63 because this is a regression that affects Firefox starting with this version and from an end-user perspective, snippets are part of the product. Once this is fixed in GitHub, this bug should be marked as fixed and the Firefox63 tracking flag changed from affected to fixed.

Comment 8

[Giorgos Logiotatidis [:giorgos]]

Fixed in https://github.com/mozmeao/snippets-service/commit/ac6711b41f59983813ac29f727ebe32d0c420115