If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

New Navigation preference pane

VERIFIED FIXED

Status

Camino Graveyard
Preferences
--
enhancement
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: William Dell Wisner, Assigned: Mike Pinkerton (not reading bugmail))

Tracking

Details

Attachments

(5 attachments)

(Reporter)

Description

16 years ago
Implementation of Navigation preference pane.
(Reporter)

Comment 1

16 years ago
Created attachment 85259 [details]
Navigation prefPane nib and implementation

See also patch attached to bug #147620 which includes changes to
project.pbxproj to arrange for this bundle to be built.
(Reporter)

Comment 2

16 years ago
Bug #147620 contains the implementation of preference options presented by this
UI and relevant additions to project.pbxproj for building.
(Reporter)

Comment 3

16 years ago
Oh, and the attachment is a .tar.bz2.

Comment 4

16 years ago
->pinkerton
Assignee: saari → pinkerton
(Reporter)

Updated

16 years ago
Depends on: 147620
(Assignee)

Comment 5

16 years ago
i don't recall seeing the pref panel impl in the referenced bug. is it in the
tarfile? regardless, please attach it separately to this bug as text.
(Reporter)

Comment 6

16 years ago
The implementation is in the tarball. I will attach it separately now.
(Reporter)

Comment 7

16 years ago
Created attachment 85414 [details]
PreferencePanes/Navigation/OrgMozillaNavigatorPreferenceNavigation.h

This implementation supersedes that in the previous tarball. I originally used
org.mozilla.chimera but the main bundle identifier is org.mozilla.navigator and
I have renamed to suit.
(Reporter)

Comment 8

16 years ago
Created attachment 85415 [details]
PreferencePanes/Navigation/OrgMozillaNavigatorPreferenceNavigation.mm
(Reporter)

Comment 9

16 years ago
Created attachment 85417 [details] [diff] [review]
patch to Chimera.pbproj/project.pbxproj

Updated project to add Navigation pane to build.
(Reporter)

Comment 10

16 years ago
Created attachment 85442 [details] [diff] [review]
patch to CHGetURLCommand.mm

Adds preference checking to "open new window" behavior.
(Assignee)

Comment 11

16 years ago
checked in, with some code mods for simplicity. you might want to check out what
i did for future reference.

as an aside, i'm not sure how i feel about using tabs for panels with like 1
checkbox. the HIGs proffer the multi-tab way and the "use whitespace, luke" way
that I did in the updated Privacy panel. i guess we can duke it out. it's easy
to change, either way.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Assignee)

Comment 12

16 years ago
ok, oops, i forgot about the CHGetURLCommand patch. well, i'm still a little
unsure about it. I don't like re-using browser.tabs.opentabfor.middleclick as an
indicator of whether or not i want to open a new tab when a url loads.

perhaps we should file a new bug to discuss that rather than morphing this one
to discuss one particular pref. leaving this closed out and attachment 85442 [details] [diff] [review]
unapplied.
Navigator pref pane is in. vrfy'ing fixed w/2002.06.18.05 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.