147631 - New Navigation preference pane

Status: VERIFIED FIXED

(Camino Graveyard :: Preferences, enhancement)

Description

[William Dell Wisner]

Implementation of Navigation preference pane.

Comment 1

[William Dell Wisner]

Attachment: Navigation prefPane nib and implementation

See also patch attached to bug #147620 which includes changes to
project.pbxproj to arrange for this bundle to be built.

Comment 2

[William Dell Wisner]

Bug #147620 contains the implementation of preference options presented by this
UI and relevant additions to project.pbxproj for building.

Comment 3

[William Dell Wisner]

Oh, and the attachment is a .tar.bz2.

Comment 4

[saari (gone)]

->pinkerton

Comment 5

[Mike Pinkerton (not reading bugmail)]

i don't recall seeing the pref panel impl in the referenced bug. is it in the
tarfile? regardless, please attach it separately to this bug as text.

Comment 6

[William Dell Wisner]

The implementation is in the tarball. I will attach it separately now.

Comment 7

[William Dell Wisner]

Attachment: PreferencePanes/Navigation/OrgMozillaNavigatorPreferenceNavigation.h

This implementation supersedes that in the previous tarball. I originally used
org.mozilla.chimera but the main bundle identifier is org.mozilla.navigator and
I have renamed to suit.

Comment 8

[William Dell Wisner]

Attachment: PreferencePanes/Navigation/OrgMozillaNavigatorPreferenceNavigation.mm

Comment 9

[William Dell Wisner]

Attachment: patch to Chimera.pbproj/project.pbxproj

Updated project to add Navigation pane to build.

Comment 10

[William Dell Wisner]

Attachment: patch to CHGetURLCommand.mm

Adds preference checking to "open new window" behavior.

Comment 11

[Mike Pinkerton (not reading bugmail)]

checked in, with some code mods for simplicity. you might want to check out what
i did for future reference.

as an aside, i'm not sure how i feel about using tabs for panels with like 1
checkbox. the HIGs proffer the multi-tab way and the "use whitespace, luke" way
that I did in the updated Privacy panel. i guess we can duke it out. it's easy
to change, either way.

Comment 12

[Mike Pinkerton (not reading bugmail)]

ok, oops, i forgot about the CHGetURLCommand patch. well, i'm still a little
unsure about it. I don't like re-using browser.tabs.opentabfor.middleclick as an
indicator of whether or not i want to open a new tab when a url loads.

perhaps we should file a new bug to discuss that rather than morphing this one
to discuss one particular pref. leaving this closed out and attachment 85442 [details] [diff] [review]
unapplied.

Comment 13

[sairuh (rarely reading bugmail)]

Navigator pref pane is in. vrfy'ing fixed w/2002.06.18.05 build.