1476313 - [Static Analysis] DEAD_STORE error in xpcom/reflect/xptcall/md/unix/xptcstubs_x86_64_linux.cpp

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Robert Bartlensky [:rbartlensky]]

xpcom/reflect/xptcall/md/unix/xptcstubs_x86_64_linux.cpp:41: error: DEAD_STORE
  The value written to &result (type int) is never used.
  39.       uint32_t paramCount;
  40.       uint32_t i;
  41. >     nsresult result = NS_ERROR_FAILURE;
  42.
  43.       NS_ASSERTION(self,"no self");

Comment 1

[Andrew McCreight [:mccr8]]

Please change the other bazillion stubs files if you change this, so they stay a little more in sync.

eg almost everything from this search result:
https://searchfox.org/mozilla-central/search?q=nsresult+result&case=false&regexp=false&path=xpcom%2F

Comment 2

[Robert Bartlensky [:rbartlensky]]

Attachment: Bug 1476313: Fix DEAD_STORE errors in xpcom/reflect/xptcall/md/unix/*.

Review commit: https://reviewboard.mozilla.org/r/258068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258068/

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 8993289 [details]
Bug 1476313: Fix DEAD_STORE errors in xpcom/reflect/xptcall/md/unix/*.

https://reviewboard.mozilla.org/r/258068/#review265128

Please also fix the three occurences of this in xpcom/reflect/xptcall/md/win32/. Thanks.

Comment 4

[Robert Bartlensky [:rbartlensky]]

Comment on attachment 8993289 [details]
Bug 1476313: Fix DEAD_STORE errors in xpcom/reflect/xptcall/md/unix/*.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/258068/diff/1-2/

Comment 5

[Robert Bartlensky [:rbartlensky]]

Is my latest addition fine? It works on try.

Comment 6

[Andrew McCreight [:mccr8]]

Yeah, the win32 changes look good to me.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2374353593c
Fix DEAD_STORE errors in xpcom/reflect/xptcall/md/unix/*. r=mccr8

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e2374353593c