[Static Analysis] DEAD_STORE error in xpcom/reflect/xptcall/md/unix/xptcstubs_x86_64_linux.cpp

RESOLVED FIXED in Firefox 63

Status

()

P3
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: rbartlensky, Assigned: rbartlensky)

Tracking

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
xpcom/reflect/xptcall/md/unix/xptcstubs_x86_64_linux.cpp:41: error: DEAD_STORE
  The value written to &result (type int) is never used.
  39.       uint32_t paramCount;
  40.       uint32_t i;
  41. >     nsresult result = NS_ERROR_FAILURE;
  42.
  43.       NS_ASSERTION(self,"no self");
Please change the other bazillion stubs files if you change this, so they stay a little more in sync.

eg almost everything from this search result:
https://searchfox.org/mozilla-central/search?q=nsresult+result&case=false&regexp=false&path=xpcom%2F
Comment hidden (mozreview-request)

Comment 3

8 months ago
mozreview-review
Comment on attachment 8993289 [details]
Bug 1476313: Fix DEAD_STORE errors in xpcom/reflect/xptcall/md/unix/*.

https://reviewboard.mozilla.org/r/258068/#review265128

Please also fix the three occurences of this in xpcom/reflect/xptcall/md/win32/. Thanks.
Attachment #8993289 - Flags: review?(continuation) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 5

8 months ago
Is my latest addition fine? It works on try.
Flags: needinfo?(continuation)
Yeah, the win32 changes look good to me.
Flags: needinfo?(continuation)
(Assignee)

Updated

8 months ago
Keywords: checkin-needed

Comment 7

8 months ago
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2374353593c
Fix DEAD_STORE errors in xpcom/reflect/xptcall/md/unix/*. r=mccr8
Keywords: checkin-needed

Comment 8

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e2374353593c
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.