Closed
Bug 1476358
Opened 6 years ago
Closed 6 years ago
Replace while-loop with FindFirstBlock() in WrapFramesInFirstLineFrame()
Categories
(Core :: Layout, enhancement, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(1 file)
Found this while reading code, the while-loop in [1] can be replaced by FindFirstBlock() [2]. [1] https://dxr.mozilla.org/mozilla-central/rev/085cdfb90903d4985f0de1dc7786522d9fb45596/layout/base/nsCSSFrameConstructor.cpp#10434-10436 [2] https://dxr.mozilla.org/mozilla-central/rev/085cdfb90903d4985f0de1dc7786522d9fb45596/layout/base/nsCSSFrameConstructor.cpp#667
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8992703 [details] Bug 1476358 - Replace while-loop with FindFirstBlock() in WrapFramesInFirstLineFrame(). Daniel Holbert [:dholbert] has approved the revision. https://phabricator.services.mozilla.com/D2193
Attachment #8992703 -
Flags: review+
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee28d69a23fbe0aaafbfba5e5cb58ecf8c01ba23
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3bc43c16247e Replace while-loop with FindFirstBlock() in WrapFramesInFirstLineFrame(). r=dholbert
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3bc43c16247e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•