1476423 - add an --enable-cretonne build flag

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Nathan Froyd [:froydnj]]

We'll turn Cretonne on for Nightly-only at some point, and it'll be a lot easier to do the Cretonne integration generally and control when Cretonne gets flipped on/off specifically if we have a configure flag for such things.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: add --enable-cretonne option

Build peers for the code, sunfish for any comments about naming etc.

We're not turning it on in any configurations; this decision enables developers
to turn in on for themselves to debug errors, etc. and incrementally land
Cretonne-ish things.  We can turn it on for Nightly platforms later.

Comment 2

[Nicolas B. Pierron [:nbp — off until 29-09]]

(In reply to Nathan Froyd [:froydnj] from comment #1)
> Created attachment 8993109 [details] [diff] [review]
> add --enable-cretonne option

I heard that the project got renamed to "cranelift" since.

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Nicolas B. Pierron [:nbp] {backlog: 39} from comment #2)
> (In reply to Nathan Froyd [:froydnj] from comment #1)
> > Created attachment 8993109 [details] [diff] [review]
> > add --enable-cretonne option
> 
> I heard that the project got renamed to "cranelift" since.

Consider the patches so amended, then. :)

Comment 4

[Dan Gohman [:sunfish]]

Comment on attachment 8993109 [details] [diff] [review]
add --enable-cretonne option

Review of attachment 8993109 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, with Cretonne renamed to Cranelift :).

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8993109 [details] [diff] [review]
add --enable-cretonne option

Review of attachment 8993109 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with s/cretonne/cranelift/g.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fcf54117a3b
add --enable-cranelift option; r=gps,sunfish

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6fcf54117a3b