Closed
Bug 1476423
Opened 7 years ago
Closed 7 years ago
add an --enable-cretonne build flag
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
1.14 KB,
patch
|
gps
:
review+
sunfish
:
review+
|
Details | Diff | Splinter Review |
We'll turn Cretonne on for Nightly-only at some point, and it'll be a lot easier to do the Cretonne integration generally and control when Cretonne gets flipped on/off specifically if we have a configure flag for such things.
![]() |
Assignee | |
Comment 1•7 years ago
|
||
Build peers for the code, sunfish for any comments about naming etc.
We're not turning it on in any configurations; this decision enables developers
to turn in on for themselves to debug errors, etc. and incrementally land
Cretonne-ish things. We can turn it on for Nightly platforms later.
Attachment #8993109 -
Flags: review?(sunfish)
Attachment #8993109 -
Flags: review?(core-build-config-reviews)
Comment 2•7 years ago
|
||
(In reply to Nathan Froyd [:froydnj] from comment #1)
> Created attachment 8993109 [details] [diff] [review]
> add --enable-cretonne option
I heard that the project got renamed to "cranelift" since.
![]() |
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Nicolas B. Pierron [:nbp] {backlog: 39} from comment #2)
> (In reply to Nathan Froyd [:froydnj] from comment #1)
> > Created attachment 8993109 [details] [diff] [review]
> > add --enable-cretonne option
>
> I heard that the project got renamed to "cranelift" since.
Consider the patches so amended, then. :)
Comment 4•7 years ago
|
||
Comment on attachment 8993109 [details] [diff] [review]
add --enable-cretonne option
Review of attachment 8993109 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me, with Cretonne renamed to Cranelift :).
Attachment #8993109 -
Flags: review?(sunfish) → review+
Comment 5•7 years ago
|
||
Comment on attachment 8993109 [details] [diff] [review]
add --enable-cretonne option
Review of attachment 8993109 [details] [diff] [review]:
-----------------------------------------------------------------
r+ with s/cretonne/cranelift/g.
Attachment #8993109 -
Flags: review?(core-build-config-reviews) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fcf54117a3b
add --enable-cranelift option; r=gps,sunfish
![]() |
||
Comment 7•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•